Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Landing page visual change footer part #4463

Merged
merged 8 commits into from
Dec 10, 2022
Merged

fix: Landing page visual change footer part #4463

merged 8 commits into from
Dec 10, 2022

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Dec 8, 2022 •
edited

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@Jarsen136 Jarsen136 requested a review from a team as a code owner December 8, 2022 17:19
@Jarsen136 Jarsen136 requested review from preschian and removed request for a team December 8, 2022 17:19
@kodabot
Copy link
Collaborator

kodabot commented Dec 8, 2022

SUCCESS @Jarsen136 PR for issue #4458 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Dec 8, 2022 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 0f1a7b4
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/6394bc4e838e4b0008ff42f1
😎 Deploy Preview https://deploy-preview-4463--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@prachi00
Copy link
Member

prachi00 commented Dec 8, 2022

@Jarsen136
Screen Shot 2022-12-08 at 9 54 44 AM
the footer is still inside the footer container, it should be overflowing to the container above it

@Jarsen136
Copy link
Contributor Author

@Jarsen136 the footer is still inside the footer container, it should be overflowing to the container above it

Hey, @prachi00 I'm not sure why I should adjust the dom structure as you say. Could you pls tell me why? I think the target of the original issue is to render the background of the footer properly, and not to affect the other part. Or have I missed something in the figma design 👀

@prachi00
Copy link
Member

prachi00 commented Dec 9, 2022

@Jarsen136 the footer is still inside the footer container, it should be overflowing to the container above it

Hey, @prachi00 I'm not sure why I should adjust the dom structure as you say. Could you pls tell me why? I think the target of the original issue is to render the background of the footer properly, and not to affect the other part. Or have I missed something in the figma design 👀

Screen Shot 2022-12-08 at 11 39 43 PM

so this is how it is suppose to look like with the footer image overflowing to the top instead of just staying in footer, right @exezbcz ? but there were issues with z-index and items not being clickable

@Jarsen136
Copy link
Contributor Author

Screen Shot 2022-12-08 at 11 39 43 PM

so this is how it is suppose to look like with the footer image overflowing to the top instead of just staying in footer, right @exezbcz ? but there were issues with z-index and items not being clickable

Oh my bad. Thanks for your answer. now I got it.

@Jarsen136
Copy link
Contributor Author

✅ UPDATED

image

image

@exezbcz
Copy link
Member

exezbcz commented Dec 9, 2022

Screen Shot 2022-12-08 at 11 39 43 PM so this is how it is suppose to look like with the footer image overflowing to the top instead of just staying in footer, right @exezbcz ? but there were issues with z-index and items not being clickable

Oh my bad. Thanks for your answer. now I got it.

yup, sorry for the confusion, one thing left - why is the dark mode blurred shape not in footer? It should have the same position as in light mode.
Thanks!
image

@Jarsen136
Copy link
Contributor Author

yup, sorry for the confusion, one thing left - why is the dark mode blurred shape not in footer? It should have the same position as in light mode. Thanks!

Because I see that in the figma : ) I will place it to where as in light mode.
image

@Jarsen136
Copy link
Contributor Author

Jarsen136 commented Dec 9, 2022 •
edited

✅ UPDATED
dark mode
image

light mode
image

@exezbcz
Copy link
Member

exezbcz commented Dec 9, 2022

yup, sorry for the confusion, one thing left - why is the dark mode blurred shape not in footer? It should have the same position as in light mode. Thanks!

Because I see that in the figma : ) I will place it to where as in light mode. image

xd, that makes sense; I wasn't too concerned with the organization in figma:DDD. Thanks again

@prachi00
Copy link
Member

prachi00 commented Dec 9, 2022

Screen Shot 2022-12-09 at 10 33 01 AM

okay looks good, I am not sure about the other pages though @exezbcz

@exezbcz
Copy link
Member

exezbcz commented Dec 9, 2022

upss

  • The line is missing there. (top of the footer)
  • Do you know why it has the grey background? I tried to open the svg and it looks fine.

@yangwao
Copy link
Member

yangwao commented Dec 10, 2022

can we merge

@codeclimate
Copy link

codeclimate bot commented Dec 10, 2022

Code Climate has analyzed commit 0f1a7b4 and detected 0 issues on this pull request.

View more on Code Climate.

@Jarsen136
Copy link
Contributor Author

  • The line is missing there. (top of the footer)

✅ Done

  • Do you know why it has the grey background? I tried to open the svg and it looks fine.

✅ Done
It's because the default color of the html element is grey (according to the previous code). It's not related to the svg background. Now I set the correct default color.

Now the footer on all pages was changed. Is it looks good to you?
image

image

image

@Jarsen136
Copy link
Contributor Author

can we merge !

I guess yes once the code review and visual check is OK.

@yangwao
Copy link
Member

yangwao commented Dec 10, 2022

pay 40 usd

@yangwao yangwao merged commit 5d17df7 into kodadot:main Dec 10, 2022
@yangwao
Copy link
Member

yangwao commented Dec 10, 2022

😍 Perfect, I’ve sent the payout
💵 $40 @ 29.87 USD/KSM ~ 1.339 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0x17297f85a96bdf5c3d4bc76b5db81d70bfe9d75b9e8094e651a7d2e0a0413ddf

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Dec 10, 2022
This was referenced Dec 12, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian Awaiting requested review from preschian preschian is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
paid pull-request has been paid S-visual-ok-✅
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Landing page visual change footer part
5 participants
@Jarsen136 @kodabot @prachi00 @exezbcz @yangwao