Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missing showing cancelled/withdrawn offers #4472

Merged
merged 2 commits into from
Dec 10, 2022

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
    /bsx/gallery/1437594557-12

image

@Jarsen136 Jarsen136 requested a review from a team as a code owner December 10, 2022 17:28
@Jarsen136 Jarsen136 requested review from prachi00 and removed request for a team December 10, 2022 17:28
@netlify
Copy link

netlify bot commented Dec 10, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 0df2c21
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/6394ce15af8f8d0008c13369
😎 Deploy Preview https://deploy-preview-4472--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodabot
Copy link
Collaborator

kodabot commented Dec 10, 2022

SUCCESS @Jarsen136 PR for issue #4468 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@yangwao
Copy link
Member

yangwao commented Dec 10, 2022

At https://deploy-preview-4472--koda-nuxt.netlify.app/bsx/gallery/1437594557-12?redesign=true

It seems on withdrawn there should be

  • "cancelled" with k-red

image

Like you can see here

image

@yangwao
Copy link
Member

yangwao commented Dec 10, 2022

Just quickly chatted with @exezbcz. It's just temporary to see all offers from the item. Later we will probably remove it.

@codeclimate
Copy link

codeclimate bot commented Dec 10, 2022

Code Climate has analyzed commit 0df2c21 and detected 0 issues on this pull request.

View more on Code Climate.

@Jarsen136
Copy link
Contributor Author

Jarsen136 commented Dec 10, 2022

✅ UPDATED

image

@yangwao
Copy link
Member

yangwao commented Dec 10, 2022

pay 50 usd

@yangwao yangwao merged commit fa75b53 into kodadot:main Dec 10, 2022
@yangwao
Copy link
Member

yangwao commented Dec 10, 2022

😍 Perfect, I’ve sent the payout
💵 $50 @ 29.87 USD/KSM ~ 1.674 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0xb6d4f1299b0c835afb381bc297d88d544a4050e3b05831b9ae7222030b6bf41a

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Dec 10, 2022
@yangwao
Copy link
Member

yangwao commented Dec 10, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing showing cancelled/withdrawn offers
3 participants