Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bring back galleryItem price chart data #4484

Merged
merged 2 commits into from
Dec 16, 2022
Merged

fix: bring back galleryItem price chart data #4484

merged 2 commits into from
Dec 16, 2022

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

@Jarsen136 Jarsen136 requested a review from a team as a code owner December 13, 2022 05:45
@Jarsen136 Jarsen136 requested review from prachi00 and removed request for a team December 13, 2022 05:45
@netlify
Copy link

netlify bot commented Dec 13, 2022 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit c6b7410
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/639c36a8d3907b0008fd4a4a
😎 Deploy Preview https://deploy-preview-4484--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodabot
Copy link
Collaborator

kodabot commented Dec 13, 2022

SUCCESS @Jarsen136 PR for issue #4482 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@codeclimate
Copy link

codeclimate bot commented Dec 13, 2022

Code Climate has analyzed commit 70135ad and detected 0 issues on this pull request.

View more on Code Climate.

@prachi00 prachi00 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Dec 14, 2022
preschian
preschian reviewed Dec 16, 2022
View reviewed changes
components/gallery/GalleryItemTabsPanel/GalleryItemTabsPanel.vue Outdated
@@ -20,6 +20,10 @@
<!-- chart -->
<o-tab-item value="2" :label="$t('tabs.chart')" class="p-5">
<PriceChart class="mt-4" :price-chart-data="priceChartData" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it's better to create a new component GalleryItemChart and wrap this component inside

<PriceChart />
<LazyGalleryHistory />

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense. I have updated it.

roiLeo
roiLeo approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ wfm
Screenshot 2022-12-16 at 11-08-53 KodaDot - Kusama NFT Market Explorer

@roiLeo roiLeo added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Dec 16, 2022
@yangwao
Copy link
Member

yangwao commented Dec 16, 2022

pay 50

@yangwao yangwao merged commit 243c50a into kodadot:main Dec 16, 2022
@yangwao
Copy link
Member

yangwao commented Dec 16, 2022

😍 Perfect, I’ve sent the payout
💵 $50 @ 26.64 USD/KSM ~ 1.877 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0x2cc9ade1555d2e5e8412da97528add76c62ddafab58aa254624dba092a57137d

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian left review comments

@roiLeo roiLeo roiLeo approved these changes

@prachi00 prachi00 prachi00 approved these changes

Assignees
No one assigned
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GalleryItem price chart data
6 participants
@Jarsen136 @kodabot @yangwao @preschian @roiLeo @prachi00