Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Subwallet mobile app #4494

Merged
merged 2 commits into from
Dec 18, 2022
Merged

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Dec 14, 2022

Is it Open Source?

PR Type

  • Feature

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Had issue bounty label?

  • Fill up your KSM address: Payout

Screenshot 📸

Screenshot_20221214-103812(1)

@roiLeo roiLeo requested a review from a team as a code owner December 14, 2022 09:09
@roiLeo roiLeo requested review from prachi00 and removed request for a team December 14, 2022 09:09
@netlify
Copy link

netlify bot commented Dec 14, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit f006fde
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63999865ee28fe000851de7a
😎 Deploy Preview https://deploy-preview-4494--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@roiLeo
Copy link
Contributor Author

roiLeo commented Dec 14, 2022

App crash when I search preview url..

@codeclimate
Copy link

codeclimate bot commented Dec 14, 2022

Code Climate has analyzed commit f006fde and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo
Copy link
Contributor Author

roiLeo commented Dec 14, 2022

@yangwao
Copy link
Member

yangwao commented Dec 14, 2022

cc @RyanDinh8

@yangwao
Copy link
Member

yangwao commented Dec 16, 2022

@RyanDinh8 any idea?

@yangwao
Copy link
Member

yangwao commented Dec 18, 2022

pay 60 usd

let's try

@yangwao yangwao merged commit 88e98b0 into kodadot:main Dec 18, 2022
@yangwao
Copy link
Member

yangwao commented Dec 18, 2022

😍 Perfect, I’ve sent the payout
💵 $60 @ 25.2 USD/KSM ~ 2.381 $KSM
🧗 GemsyWUUtZU5HAiEQJqqgVz4YkekKXnmutYryBhbcVD4YW3
🔗 0x0d85d4cfec4a579d897c512113a1b22ea3c7f5de7700a5d8309a502aaf037100

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Dec 18, 2022
@RyanDinh8
Copy link

RyanDinh8 commented Dec 26, 2022

Hi @yangwao,

Sorry I missed this. I just checked, and it worked very smoothly on the SubWallet mobile app. We have also added Kodadot to the predefined list in our dapp browser.

Just another small thing: It would be great if you can help add the deeplink so that when the user clicks SubWallet (if they access Kodadot dapp in a mobile browser), it will direct the user to the dapp browser tab in SubWallet mobile:

I've included a demo here:

IMG_4532.MP4

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SubWallet (mobile) as an option to connect to Kodadot dapp
3 participants