Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ upgrade sub-api dependencies #4501

Merged
merged 2 commits into from
Dec 15, 2022
Merged

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Dec 14, 2022

Next step could refactor fetchBalance:

const api = await ApiFactory.useApiInstance(endpoint)
const identityBalance = await balanceOf(api, address)

PR Type

  • Bugfix

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Had issue bounty label?

  • Fill up your KSM address: Payout

Screenshot 📸

Capture d’écran 2022-12-14 à 3 49 41 PM

Note

@roiLeo roiLeo requested a review from a team as a code owner December 14, 2022 14:52
@roiLeo roiLeo requested review from preschian and removed request for a team December 14, 2022 14:52
@netlify
Copy link

netlify bot commented Dec 14, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 5efd9ed
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/639acceaacade200077f3438
😎 Deploy Preview https://deploy-preview-4501--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@yangwao
Copy link
Member

yangwao commented Dec 14, 2022

@JustLuuuu you've got lucky 😍

Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jarsen136 Jarsen136 added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked labels Dec 15, 2022
@codeclimate
Copy link

codeclimate bot commented Dec 15, 2022

Code Climate has analyzed commit 5efd9ed and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo roiLeo merged commit 46b85a3 into kodadot:main Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Balance on RMRK doesn't work (api issue?)
4 participants