Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 correct url for highest sales popover #4502

Merged
merged 3 commits into from
Dec 16, 2022

Conversation

petersopko
Copy link
Contributor

@petersopko petersopko commented Dec 14, 2022

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

@petersopko petersopko requested a review from a team as a code owner December 14, 2022 19:42
@petersopko petersopko requested review from preschian and removed request for a team December 14, 2022 19:42
@netlify
Copy link

netlify bot commented Dec 14, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit fec389d
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/639aecaa3d00c60008ece96d
😎 Deploy Preview https://deploy-preview-4502--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodabot
Copy link
Collaborator

kodabot commented Dec 14, 2022

SUCCESS @petersopko PR for issue #4500 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

Copy link
Member

@preschian preschian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@codeclimate
Copy link

codeclimate bot commented Dec 15, 2022

Code Climate has analyzed commit fec389d and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo roiLeo added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked labels Dec 16, 2022
@yangwao
Copy link
Member

yangwao commented Dec 16, 2022

pay 30 usd

@yangwao yangwao merged commit d5bf8d5 into kodadot:main Dec 16, 2022
@yangwao
Copy link
Member

yangwao commented Dec 16, 2022

😍 Perfect, I’ve sent the payout
💵 $30 @ 26.37 USD/KSM ~ 1.138 $KSM
🧗 FNyt7T1xdbhN7dagf7yGYCRJuE3R45VmTCE3tjzy1rKxa7y
🔗 0xa7830f09b3a01e4a3a09cc5a9a74cef93f4d241d94a18f53f22dd27507f2c995

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Highest sales card is showing incorrect url
6 participants