Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 repeated search works #4503

Merged
merged 3 commits into from
Dec 16, 2022
Merged

Conversation

petersopko
Copy link
Contributor

@petersopko petersopko commented Dec 14, 2022

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
KodaDot.-.Kusama.NFT.Market.Explorer._.Low.Carbon.NFTs.-.Google.Chrome.2022-12-14.21-37-26.mp4

@petersopko petersopko requested a review from a team as a code owner December 14, 2022 20:34
@petersopko petersopko requested review from Jarsen136 and removed request for a team December 14, 2022 20:34
@kodabot
Copy link
Collaborator

kodabot commented Dec 14, 2022

SUCCESS @petersopko PR for issue #4490 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Dec 14, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 41871da
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/639adb561b176f0007dcdbd8
😎 Deploy Preview https://deploy-preview-4503--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small stuff

components/search/Search.vue Outdated Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Dec 15, 2022

Code Climate has analyzed commit 41871da and detected 0 issues on this pull request.

View more on Code Climate.

@Jarsen136 Jarsen136 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Dec 15, 2022
@yangwao
Copy link
Member

yangwao commented Dec 16, 2022

pay 40 usd

@yangwao yangwao merged commit 9b042e9 into kodadot:main Dec 16, 2022
@yangwao
Copy link
Member

yangwao commented Dec 16, 2022

😍 Perfect, I’ve sent the payout
💵 $40 @ 26.53 USD/KSM ~ 1.508 $KSM
🧗 FNyt7T1xdbhN7dagf7yGYCRJuE3R45VmTCE3tjzy1rKxa7y
🔗 0x3971cbebc412e83140008893e6f33a6b29c11c11e6f7e796ff169eb0c536561e

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Dec 16, 2022
@petersopko
Copy link
Contributor Author

😍 Perfect, I’ve sent the payout 💵 $40 @ 26.53 USD/KSM ~ 1.508 $KSM 🧗 FNyt7T1xdbhN7dagf7yGYCRJuE3R45VmTCE3tjzy1rKxa7y 🔗 0x3971cbebc412e83140008893e6f33a6b29c11c11e6f7e796ff169eb0c536561e

🪅 Let’s grab another issue and get rewarded! 🪄 github.com/kodadot/nft-gallery/issues

this one didn't work 👀

@yangwao yangwao removed the paid pull-request has been paid label Dec 18, 2022
@yangwao
Copy link
Member

yangwao commented Dec 18, 2022

pay 40 usd

@yangwao
Copy link
Member

yangwao commented Dec 18, 2022

😍 Perfect, I’ve sent the payout
💵 $40 @ 25.2 USD/KSM ~ 1.587 $KSM
🧗 FNyt7T1xdbhN7dagf7yGYCRJuE3R45VmTCE3tjzy1rKxa7y
🔗 0xa15007fb3fd7519a1132f26ad6ba4b6bddd8fceb85c5c84c0039d952eb9bd3b1

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added paid pull-request has been paid fixed-payment labels Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repeated Search doesn't work
4 participants