-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redesign: [price-section] [desktop] [ui-only] buy, offer, list, transfer, change price, and not listed section #4506
Conversation
WARNING @preschian PR for issue #4505 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #4505 |
✅ Deploy Preview for koda-nuxt ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ready for review cc @roiLeo. please note, this is UI only. so the button still didn't work. I put them in a separate task to integrate the button #4231 (comment). for integration, should be able to tackle in parallel PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated, using https://vueuse.org/core/onclickoutside/
renamed
updated using radio button |
Nice job, it looks really good! One issue, we had chat in the parent issue about the responsive version. AnnndI have to rethink it because for example from 1024 to 768px does not makes sense to have this animation etc. I did not think about it that much. I'll attempt to come up with something better - it seems to be a popup that will transform into a modal on mobile. I mean on desktop with full view it looks really good and i am conviced this was good solution, but looking at the ui in the device toolbar i think we have to change few things - maybe use this for large screens and then change to something else, but like you said, this will result in maintaining of more than 3 types.... This was my fault and i am sorry for that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ code lgtm, we can continue with this
eh, it's ok, no need to be sorry for that 👍
yes, because I already started on the desktop animation. At least deliver that first for v1.0 and adjust a little bit for mobile based on the desktop version. let's focus to deliver v1.0 first, and then we can figure it out later for v.1.1 |
Code Climate has analyzed commit 4dd681f and detected 0 issues on this pull request. View more on Code Climate. |
Yes, agree with this approach. |
Hi! nice job feedback
rest i think would be fixed in #4444 , for example stretching the card to something like this, which isnt expected behavior Thanks! |
I guess let's merge it and then we can look adding #4531 and then through feedback process to tune details? |
I'm moving this forward |
Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR Type
Context
formatDistanceToNowStrict
to trimabout
Before submitting pull request, please make sure:
Optional
Had issue bounty label?
Community participation
Screenshot 📸