Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚡ fix identity reactivity #4508

Merged
merged 5 commits into from
Dec 16, 2022
Merged

⚡ fix identity reactivity #4508

merged 5 commits into from
Dec 16, 2022

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented Dec 15, 2022 •
edited

make identity reactive
address and on-chain identity updates without needing to refresh page

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

  • Closes #<issue_number>
  • Requires deployment <>

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
    Screenshot from 2022-12-15 17-06-38
    Screenshot from 2022-12-15 17-06-52

@daiagi daiagi requested a review from a team as a code owner December 15, 2022 09:52
@daiagi daiagi requested review from preschian and removed request for a team December 15, 2022 09:52
@netlify
Copy link

netlify bot commented Dec 15, 2022 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 10b687b
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/639b192570c01b0009fb9c3a
😎 Deploy Preview https://deploy-preview-4508--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented Dec 15, 2022

Code Climate has analyzed commit 10b687b and detected 0 issues on this pull request.

View more on Code Climate.

roiLeo
roiLeo approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed I came across this bug, nice fix.
✅ works for me

edit: what would happen if I set a different identity on my address? is it something possible?
example: On BSX -> XXX; On Kusama -> YYY

@roiLeo roiLeo added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Dec 16, 2022
@daiagi
Copy link
Contributor Author

daiagi commented Dec 16, 2022

edit: what would happen if I set a different identity on my address? is it something possible?
example: On BSX -> XXX; On Kusama -> YYY

Good question. I haven't tested that scenario

@yangwao
Copy link
Member

yangwao commented Dec 16, 2022

example: On BSX -> XXX; On Kusama -> YYY

Now we are picking it up from Kusama iirc, BSX doesn't have an on-chain identity module.

In the future, we would offset it using KILT probably

@yangwao
Copy link
Member

yangwao commented Dec 16, 2022

pay 50 usd

@yangwao yangwao merged commit 373ea0e into kodadot:main Dec 16, 2022
@yangwao
Copy link
Member

yangwao commented Dec 16, 2022

😍 Perfect, I’ve sent the payout
💵 $50 @ 26.38 USD/KSM ~ 1.895 $KSM
🧗 EfmnRhHaQqfT3phm4cUCHCU3gFVDoSPR1U9WXzMRQBMqZ4L
🔗 0xf7e9c42ef552487ce214bf47204b1affa0650f39e6c33371a9d292059c88a3f0

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Dec 16, 2022
@daiagi
Copy link
Contributor Author

daiagi commented Dec 16, 2022

@yangwao the payment failed （InsufficientBalance）

@yangwao yangwao removed the paid pull-request has been paid label Dec 18, 2022
@yangwao
Copy link
Member

yangwao commented Dec 18, 2022

yes

pay 50 usd

@yangwao
Copy link
Member

yangwao commented Dec 18, 2022

😍 Perfect, I’ve sent the payout
💵 $50 @ 25.19 USD/KSM ~ 1.985 $KSM
🧗 EfmnRhHaQqfT3phm4cUCHCU3gFVDoSPR1U9WXzMRQBMqZ4L
🔗 0x538697071956f7808d916e7fd0293a4dfa7ab2ea7c642a27bde03736e20f721c

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added paid pull-request has been paid fixed-payment labels Dec 18, 2022
@yangwao yangwao mentioned this pull request Dec 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo approved these changes

@preschian preschian Awaiting requested review from preschian preschian is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@daiagi @yangwao @roiLeo