Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 bsx withdraw offer as owner #4540

Merged
merged 3 commits into from
Jan 1, 2023
Merged

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Dec 21, 2022

I had difficulty testing it on Rococo.
IMO, Offer features need a slight rework.

752out

PR Type

  • Bugfix

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at /snek/gallery/331660682-2

Screenshot 📸

Screenshot 2022-12-21 at 15-18-47 Shader 002 KodaDot - Kusama NFT Market Explorer

@roiLeo roiLeo requested a review from a team as a code owner December 21, 2022 14:25
@roiLeo roiLeo requested review from preschian and removed request for a team December 21, 2022 14:25
@netlify
Copy link

netlify bot commented Dec 21, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 0ccdf99
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63a4087be096dd00092a9ba0
😎 Deploy Preview https://deploy-preview-4540--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@preschian preschian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove unused import { isSameAccount } from '~/utils/account'. otherwise code-lgtm

@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Dec 22, 2022
@codeclimate
Copy link

codeclimate bot commented Dec 22, 2022

Code Climate has analyzed commit 0ccdf99 and detected 0 issues on this pull request.

View more on Code Climate.

@yangwao
Copy link
Member

yangwao commented Jan 1, 2023

Let's see

@yangwao yangwao merged commit 9673691 into kodadot:main Jan 1, 2023
@roiLeo
Copy link
Contributor Author

roiLeo commented Jan 4, 2023

I have a doubt about this feature, what happens when there is multiple offers? waiting for kodadot/snek#127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Withdraw offers as token owner
3 participants