feat: integrate offer button #4554

preschian · 2022-12-23T09:43:59Z

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

Bugfix
Feature
Refactoring
Redesign

Context

Closes Gallery Item Desktop - integrate offer #4542

Before submitting pull request, please make sure:

My contribution builds clean without any errors or warnings
I've merged recent default branch -- main and I've no conflicts
I've tried to respect high code quality standards
I've didn't break any original functionality
I've posted a screenshot of demonstrated change in this PR

Optional

I've tested it at </bsx/collection>
I've tested PR on mobile
I've written unit tests 🧪
I've found edge cases

Had issue bounty label?

Fill up your KSM address: Payout

Community participation

Are you at KodaDot Discord?

Screenshot 📸

My fix has changed something on UI; a screenshot is best to understand changes for others.

netlify · 2022-12-23T09:44:04Z

✅ Deploy Preview for koda-nuxt ready!

Name	Link
🔨 Latest commit	`698aea9`
🔍 Latest deploy log	https://app.netlify.com/sites/koda-nuxt/deploys/63c0fe47af4250000963d121
😎 Deploy Preview	https://deploy-preview-4554--koda-nuxt.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

kodabot · 2022-12-23T09:44:04Z

WARNING @preschian PR for issue #4542 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #4542

preschian · 2022-12-23T09:47:18Z

I need your help @roiLeo @Jarsen136. Does the offer button work on your side on this PR? I just followed the submit() function on AvailableActions. If not, What do I miss anyway?

roiLeo · 2022-12-23T10:00:06Z

I need your help @roiLeo @Jarsen136. Does the offer button work on your side on this PR? I just followed the submit() function on AvailableActions. If not, What do I miss anyway?

wfm, block hash 0xa537886e39455a2d6e0cde1f96177433b5d4c65d996422f9abf0dc1431c6c9ad

it's been a few weeks that Snek [Rococo] endpoint is "stuck" but you can see that the call has been made on chain

note: success toast didn't show up

Jarsen136 · 2022-12-23T10:40:00Z

I need your help @roiLeo @Jarsen136. Does the offer button work on your side on this PR? I just followed the submit() function on AvailableActions. If not, What do I miss anyway?

WFM too

preschian · 2022-12-23T12:41:37Z

wfm, block hash 0xa537886e39455a2d6e0cde1f96177433b5d4c65d996422f9abf0dc1431c6c9ad

it's been a few weeks that Snek [Rococo] endpoint is "stuck" but you can see that the call has been made on chain

note: success toast didn't show up

WFM too

I see, thanks. I will refactor a little bit and then would be ready for review

composables/useToast.ts

yangwao · 2022-12-23T16:40:25Z

Snek [Rococo] endpoint is "stuck"

After Brick I sense @vikiival updated only snek@05 for BSX, not for Rococo?

vikiival · 2022-12-23T16:58:25Z

Looks like something is wrong with offers. I pinged BSX team

yangwao · 2023-01-01T21:31:23Z

I've made offer on this one https://deploy-preview-4554--koda-nuxt.netlify.app/bsx/gallery/2608295324-7

But it seems on old one doesn't show up.

https://basilisk.subscan.io/extrinsic/2460385-2

Oh, seems it's on Basilisk team side something ...

vikiival · 2023-01-11T12:28:14Z

Offers should be already available

roiLeo · 2023-01-11T12:43:44Z

Offers should be already available

Tx is good but it's not visible for me on snek Rococo

vikiival · 2023-01-11T13:55:43Z

Tx is good but it's not visible for me on snek Rococo

Because the one that @yangwao made was on BSX

composables/useTransaction.ts

roiLeo

On dark mode text is hard to see

I've tested it on /snek/gallery/659233203-7?redesign=true and when I log item I find a wrong tokenId

{
  "interaction": "MAKE_OFFER",
  "currentOwner": "bXhWeVLtArWauM8UmbaVdDmXmo5uSDk6DAa2YxQ5zbt2sDcbW",
  "day": 3,
  "price": ".1",
  "tokenId": "659233203-659233203-7",
  "urlPrefix": "snek",
  "successMessage": "Offer successfully created",
  "errorMessage": "Failed to send item"
}

preschian · 2023-01-12T10:08:56Z

I've tested it on /snek/gallery/659233203-7?redesign=true and when I log item I find a wrong tokenId

ouch, updated

roiLeo · 2023-01-12T10:23:15Z

✅ Block hash: 0xe77afe69d0712c73bfc45df5a9ac5300ba46d22bb05bf548bfd281ab24e76546 on Rococo

Still blocked by kodadot/snek#130

Jarsen136

code lgtm

vikiival · 2023-01-12T14:26:59Z

Merged

kodadot/snek#136

roiLeo · 2023-01-12T14:45:17Z

Merged

kodadot/snek#136

https://squiki.kodadot.workers.dev/status/snekk

new endpoint again??? (https://squid.subsquid.io/snekk/graphql)

vikiival · 2023-01-12T14:50:02Z

new endpoint again???

Following good practises
https://docs.subsquid.io/deploy-squid/promote-to-production/

preschian · 2023-01-12T14:58:52Z

Merged
kodadot/snek#136

squiki.kodadot.workers.dev/status/snekk

new endpoint again??? (https://squid.subsquid.io/snekk/graphql)

should I change it to this endpoint in this PR?

roiLeo · 2023-01-12T15:07:14Z

Yeah!! offers are back

roiLeo

✅ wfm 🚀

vikiival

Smol

vikiival · 2023-01-12T15:35:58Z

composables/transaction/transactionOffer.ts

+
+import type { ActionOffer } from './types'
+
+export async function execTsxOffer(item: ActionOffer, api, executeTransaction) {


execTsxOffer

exec{What}Tx ?

Suggested change

export async function execTsxOffer(item: ActionOffer, api, executeTransaction) {

export async function exectMakeOfferTx(item: ActionOffer, api, executeTransaction) {

vikiival

let it roll 🎲

codeclimate · 2023-01-13T06:46:53Z

Code Climate has analyzed commit 698aea9 and detected 0 issues on this pull request.

View more on Code Climate.

feat: integrate offer button

beaddba

preschian added 2 commits December 23, 2022 20:31

feat: adjust notif

975f032

fix: undefined properties

bcc94ab

preschian marked this pull request as ready for review December 23, 2022 14:01

preschian requested a review from a team as a code owner December 23, 2022 14:01

preschian requested review from Jarsen136 and removed request for a team December 23, 2022 14:01

Jarsen136 reviewed Dec 23, 2022

View reviewed changes

composables/useToast.ts Show resolved Hide resolved

preschian added 2 commits December 24, 2022 11:51

feat: add useToast and add vue-i18n into vue d.ts

a8f3bd8

fix: twitterUri

6421873

yangwao added the A-basilisk issues related to basilisk parachain label Jan 1, 2023

roiLeo self-requested a review January 4, 2023 10:52

roiLeo added the S-blocked-✋ label Jan 4, 2023

preschian marked this pull request as draft January 11, 2023 16:59

preschian added 2 commits January 12, 2023 13:37

Merge branch 'main' of github.com:kodadot/nft-gallery into offer-button

0f84c47

refactor: move transaction as composables

fc62011

codeclimate bot reviewed Jan 12, 2023

View reviewed changes

composables/useTransaction.ts Show resolved Hide resolved

preschian marked this pull request as ready for review January 12, 2023 07:46

roiLeo reviewed Jan 12, 2023

View reviewed changes

fix: offer input dark mode and tokenid

55e7812

preschian added 3 commits January 12, 2023 17:51

refactor: unused loading

ae8f759

refactor: reduce cognitive

1056e76

refactor: deepsource

2a8b2b9

Jarsen136 approved these changes Jan 12, 2023

View reviewed changes

roiLeo added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked labels Jan 12, 2023

roiLeo approved these changes Jan 12, 2023

View reviewed changes

Merge branch 'main' into offer-button

dc89bc6

vikiival requested changes Jan 12, 2023

View reviewed changes

chore: rename function

d2cf60e

vikiival approved these changes Jan 12, 2023

View reviewed changes

preschian and others added 3 commits January 13, 2023 13:38

fix: number of digits on price and floor difference

083c012

Merge branch 'main' of github.com:kodadot/nft-gallery into offer-button

41cf2a3

Merge pull request #4681 from kodadot/fix/digit-numbers

698aea9

yangwao merged commit 07a27a0 into main Jan 13, 2023

yangwao deleted the offer-button branch January 13, 2023 08:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: integrate offer button #4554

feat: integrate offer button #4554

preschian commented Dec 23, 2022 •

edited

netlify bot commented Dec 23, 2022 •

edited

kodabot commented Dec 23, 2022

preschian commented Dec 23, 2022 •

edited

roiLeo commented Dec 23, 2022 •

edited

Jarsen136 commented Dec 23, 2022

preschian commented Dec 23, 2022

yangwao commented Dec 23, 2022

vikiival commented Dec 23, 2022

yangwao commented Jan 1, 2023

vikiival commented Jan 11, 2023

roiLeo commented Jan 11, 2023

vikiival commented Jan 11, 2023

roiLeo left a comment

preschian commented Jan 12, 2023

roiLeo commented Jan 12, 2023

Jarsen136 left a comment

vikiival commented Jan 12, 2023

roiLeo commented Jan 12, 2023

vikiival commented Jan 12, 2023

preschian commented Jan 12, 2023 •

edited

roiLeo commented Jan 12, 2023

roiLeo left a comment

vikiival left a comment

vikiival Jan 12, 2023

vikiival left a comment

codeclimate bot commented Jan 13, 2023


		import type { ActionOffer } from './types'

		export async function execTsxOffer(item: ActionOffer, api, executeTransaction) {

	export async function execTsxOffer(item: ActionOffer, api, executeTransaction) {
	export async function exectMakeOfferTx(item: ActionOffer, api, executeTransaction) {

feat: integrate offer button #4554

feat: integrate offer button #4554

Conversation

preschian commented Dec 23, 2022 • edited

PR Type

Context

Before submitting pull request, please make sure:

Optional

Had issue bounty label?

Community participation

Screenshot 📸

netlify bot commented Dec 23, 2022 • edited

✅ Deploy Preview for koda-nuxt ready!

kodabot commented Dec 23, 2022

preschian commented Dec 23, 2022 • edited

roiLeo commented Dec 23, 2022 • edited

Jarsen136 commented Dec 23, 2022

preschian commented Dec 23, 2022

yangwao commented Dec 23, 2022

vikiival commented Dec 23, 2022

yangwao commented Jan 1, 2023

vikiival commented Jan 11, 2023

roiLeo commented Jan 11, 2023

vikiival commented Jan 11, 2023

roiLeo left a comment

Choose a reason for hiding this comment

preschian commented Jan 12, 2023

roiLeo commented Jan 12, 2023

Jarsen136 left a comment

Choose a reason for hiding this comment

vikiival commented Jan 12, 2023

roiLeo commented Jan 12, 2023

vikiival commented Jan 12, 2023

preschian commented Jan 12, 2023 • edited

roiLeo commented Jan 12, 2023

roiLeo left a comment

Choose a reason for hiding this comment

vikiival left a comment

Choose a reason for hiding this comment

vikiival Jan 12, 2023

Choose a reason for hiding this comment

vikiival left a comment

Choose a reason for hiding this comment

codeclimate bot commented Jan 13, 2023

preschian commented Dec 23, 2022 •

edited

netlify bot commented Dec 23, 2022 •

edited

preschian commented Dec 23, 2022 •

edited

roiLeo commented Dec 23, 2022 •

edited

preschian commented Jan 12, 2023 •

edited