Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: integrate buy button #4558

Merged
merged 49 commits into from
Jan 12, 2023
Merged

feat: integrate buy button #4558

merged 49 commits into from
Jan 12, 2023

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented Dec 24, 2022 •
edited

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring
  • Redesign

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@daiagi daiagi requested a review from a team as a code owner December 24, 2022 12:17
@daiagi daiagi requested review from roiLeo and removed request for a team December 24, 2022 12:17
@kodabot
Copy link
Collaborator

kodabot commented Dec 24, 2022

WARNING @daiagi PR for issue #4541 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #4541

@netlify
Copy link

netlify bot commented Dec 24, 2022 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 01a890b
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63c03a1537b07800087a3a0e
😎 Deploy Preview https://deploy-preview-4558--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@daiagi
Copy link
Contributor Author

daiagi commented Dec 24, 2022 •
edited

TODO

match Buy button disabled style to figma
disabled tooltip
translations

@daiagi daiagi marked this pull request as draft December 24, 2022 12:36
@daiagi daiagi marked this pull request as ready for review December 25, 2022 10:20
@yangwao
Copy link
Member

yangwao commented Jan 1, 2023

what's about code?

@daiagi
Copy link
Contributor Author

daiagi commented Jan 1, 2023

what's about code?

What do you mean?

@yangwao yangwao requested review from Jarsen136 and removed request for roiLeo January 1, 2023 21:22
@yangwao
Copy link
Member

yangwao commented Jan 1, 2023

What do you mean?

Asking if the code is good to go :)

@Jarsen136 can have look 👀

@roiLeo roiLeo self-requested a review January 2, 2023 08:35
roiLeo
roiLeo reviewed Jan 2, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not test it on bsx because I'm blocked by #4574

components/gallery/GalleryItemAction/GalleryItemAction.vue Outdated Show resolved Hide resolved
components/gallery/GalleryItemAction/GalleryItemAction.vue Outdated Show resolved Hide resolved
components/gallery/GalleryItemAction/GalleryItemActionSlides.vue Outdated Show resolved Hide resolved
components/gallery/GalleryItemAction/GalleryItemActionType/GalleryItemBuy.vue Show resolved Hide resolved
components/gallery/GalleryItemAction/GalleryItemActionType/GalleryItemBuy.vue Show resolved Hide resolved
@daiagi
Copy link
Contributor Author

daiagi commented Jan 9, 2023

ready to merge?

@roiLeo roiLeo self-requested a review January 9, 2023 08:56
roiLeo
roiLeo reviewed Jan 9, 2023
View reviewed changes
utils/constants.ts Outdated Show resolved Hide resolved
@yangwao yangwao requested a review from vikiival January 11, 2023 09:44
@yangwao yangwao mentioned this pull request Jan 11, 2023
Closed
@yangwao
Copy link
Member

yangwao commented Jan 11, 2023

@daiagi
Copy link
Contributor Author

daiagi commented Jan 11, 2023

@roiLeo @Jarsen136 @vikiival ready for review

@roiLeo roiLeo self-requested a review January 11, 2023 15:09
@daiagi
Copy link
Contributor Author

daiagi commented Jan 11, 2023 •
edited

disabled state looking good:
image

✔️ tested on https://deploy-preview-4558--koda-nuxt.netlify.app/snek/gallery/659233203-5

  • it takes a few moments for UI to change after buying, but as far as i can tell all is working properly

image

roiLeo
roiLeo approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on /snek/gallery/185770742-2?redesign=true

✅ works for me

@roiLeo roiLeo added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Jan 11, 2023
@yangwao
Copy link
Member

yangwao commented Jan 12, 2023

pay 110 usd

@daiagi let's resolve conflicts and we can merge it, finally buys 🤑

@yangwao
Copy link
Member

yangwao commented Jan 12, 2023

😍 Perfect, I’ve sent the payout
💵 $110 @ 27.51 USD/KSM ~ 3.999 $KSM
🧗 EfmnRhHaQqfT3phm4cUCHCU3gFVDoSPR1U9WXzMRQBMqZ4L
🔗 0xd6628388b660391ba08b082f3abdc69e19e22b4355b0c84b3b0c5af2f4bfdacf

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jan 12, 2023
@vikiival
Copy link
Member

@daiagi there is a conflict

@codeclimate
Copy link

codeclimate bot commented Jan 12, 2023

Code Climate has analyzed commit 01a890b and detected 0 issues on this pull request.

View more on Code Climate.

@daiagi
Copy link
Contributor Author

daiagi commented Jan 12, 2023

@vikiival conflict resolved

@yangwao yangwao merged commit 8266704 into kodadot:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo approved these changes

@Jarsen136 Jarsen136 Awaiting requested review from Jarsen136

@vikiival vikiival Awaiting requested review from vikiival

Assignees
No one assigned
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gallery Item Desktop - integrate buy
6 participants
@daiagi @kodabot @yangwao @roiLeo @vikiival @Jarsen136