-
-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix disabled scrolling on mobile #4559
Conversation
…-diabled-scrolling-on-mobile
✅ Deploy Preview for koda-nuxt ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- IMO, the better approach is to watch the
isMenuOpen
status change. And then control whether it should scroll.
like this way:
toggleBodyScroll(on: boolean) {
...
}
this.toggleBodyScroll(true)
this.toggleBodyScroll(false)
- There are two similar status:
isBurgerMenuOpened
andisMobileMenuOpen
. Could we try to unify them?
Code Climate has analyzed commit b869bea and detected 0 issues on this pull request. View more on Code Climate. |
deleted isMobileMenuOpen |
@yangwao pinged you on disord |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
pay 40 usd |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
@yangwao I sent you a DM on discord |
Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR Type
Context
Before submitting pull request, please make sure:
Optional
Had issue bounty label?
Community participation
Screenshot 📸