Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disabled scrolling on mobile #4559

Merged
merged 3 commits into from
Jan 1, 2023

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented Dec 25, 2022

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@daiagi daiagi requested a review from a team as a code owner December 25, 2022 11:54
@daiagi daiagi requested review from Jarsen136 and removed request for a team December 25, 2022 11:54
@kodabot
Copy link
Collaborator

kodabot commented Dec 25, 2022

SUCCESS @daiagi PR for issue #4556 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Dec 25, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit b869bea
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63aa5f3276132d00080791dc
😎 Deploy Preview https://deploy-preview-4559--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@daiagi daiagi changed the title Fix diabled scrolling on mobile Fix disabled scrolling on mobile Dec 25, 2022
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. IMO, the better approach is to watch the isMenuOpen status change. And then control whether it should scroll.

like this way:

 toggleBodyScroll(on: boolean) { 
  ...
  } 

this.toggleBodyScroll(true)
this.toggleBodyScroll(false)
  1. There are two similar status: isBurgerMenuOpened and isMobileMenuOpen. Could we try to unify them?

components/Navbar.vue Outdated Show resolved Hide resolved
components/Navbar.vue Outdated Show resolved Hide resolved
@yangwao yangwao mentioned this pull request Dec 26, 2022
1 task
@codeclimate
Copy link

codeclimate bot commented Dec 27, 2022

Code Climate has analyzed commit b869bea and detected 0 issues on this pull request.

View more on Code Climate.

@daiagi
Copy link
Contributor Author

daiagi commented Dec 27, 2022

There are two similar status: isBurgerMenuOpened and isMobileMenuOpen. Could we try to unify them?

deleted isMobileMenuOpen

@daiagi
Copy link
Contributor Author

daiagi commented Dec 27, 2022

@yangwao pinged you on disord

Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@Jarsen136 Jarsen136 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Dec 27, 2022
@yangwao
Copy link
Member

yangwao commented Jan 1, 2023

@yangwao pinged you on disord

@daiagi I haven't seen discord for month+, I was about to write to you a week ago, it's on my agenda.
Feel free to write me DM :)

@yangwao
Copy link
Member

yangwao commented Jan 1, 2023

pay 40 usd

@yangwao yangwao merged commit 6cc4df0 into kodadot:main Jan 1, 2023
@yangwao
Copy link
Member

yangwao commented Jan 1, 2023

😍 Perfect, I’ve sent the payout
💵 $40 @ 22.37 USD/KSM ~ 1.788 $KSM
🧗 EfmnRhHaQqfT3phm4cUCHCU3gFVDoSPR1U9WXzMRQBMqZ4L
🔗 0x1ad43452ccb4d4e67572a5bd03bfb17fae0a85efd5b17abd4f81ba0935c65823

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jan 1, 2023
@daiagi
Copy link
Contributor Author

daiagi commented Jan 2, 2023

@yangwao I sent you a DM on discord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Found scrolling disable issue
4 participants