Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 increase tooltip trigger area #4568

Merged
merged 3 commits into from
Jan 1, 2023
Merged

🐛 increase tooltip trigger area #4568

merged 3 commits into from
Jan 1, 2023

Conversation

petersopko
Copy link
Contributor

@petersopko petersopko commented Dec 27, 2022 •
edited

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
    image

@petersopko petersopko requested a review from a team as a code owner December 27, 2022 15:57
@petersopko petersopko requested review from Jarsen136 and removed request for a team December 27, 2022 15:57
@netlify
Copy link

netlify bot commented Dec 27, 2022 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit dd08877
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63ab353fd10e3a000873d13d
😎 Deploy Preview https://deploy-preview-4568--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented Dec 27, 2022

Code Climate has analyzed commit dd08877 and detected 0 issues on this pull request.

View more on Code Climate.

Jarsen136
Jarsen136 approved these changes Dec 28, 2022
View reviewed changes
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@Jarsen136 Jarsen136 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Dec 28, 2022
@yangwao
Copy link
Member

yangwao commented Jan 1, 2023

pay 30 usd

@yangwao yangwao merged commit 40b8160 into kodadot:main Jan 1, 2023
@yangwao
Copy link
Member

yangwao commented Jan 1, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 22.64 USD/KSM ~ 1.325 $KSM
🧗 FNyt7T1xdbhN7dagf7yGYCRJuE3R45VmTCE3tjzy1rKxa7y
🔗 0xb0dc5a8284bef9b332c3d11e334b25c6257de352ecac6c328a6af70d8fd7d8b4

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jan 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarsen136 Jarsen136 Jarsen136 approved these changes

Assignees
No one assigned
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-visual-ok-✅
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Properties are still clickable when they are empty
4 participants
@petersopko @yangwao @Jarsen136 @exezbcz