Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4581 gallery btn changes #4582

Merged
merged 6 commits into from
Jan 4, 2023
Merged

#4581 gallery btn changes #4582

merged 6 commits into from
Jan 4, 2023

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented Dec 29, 2022 •
edited
Loading

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address:
    Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@prachi00 prachi00 requested a review from a team as a code owner December 29, 2022 21:36
@prachi00 prachi00 requested review from preschian and removed request for a team December 29, 2022 21:36
@netlify
Copy link

netlify bot commented Dec 29, 2022 •
edited
Loading

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit b03b5fd
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63b5a0cb7f12cf00096a90fb
😎 Deploy Preview https://deploy-preview-4582--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@exezbcz
Copy link
Member

exezbcz commented Jan 1, 2023 •
edited
Loading

is this final versions or you'll still be working on it?

on thing is missing:
image

  • active states, when you click on the button and the dropdown popups, the button should change itself to active state

@petersopko petersopko mentioned this pull request Jan 1, 2023
Merged
17 tasks
@yangwao yangwao added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Jan 1, 2023
roiLeo
roiLeo reviewed Jan 2, 2023
View reviewed changes
components/gallery/GalleryItemAction/GalleryItemActionSection.vue
@@ -39,7 +39,7 @@ watchEffect(async () => {
const chainSymbol = urlPrefix.value === 'rmrk' ? unit.value : symbol

priceChain.value = `${parseFloat(price).toFixed(2)} ${chainSymbol}`
priceUsd.value = `$${Math.round(Number(price) * Number(ksmPrice))}`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's here to show "$" sign

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesnt the issue mention to remove the dollar sign since we show usd already?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aight, then we don't need template literals here.
Should we keep "$" sign in GalleryItemOffers too?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep "$" sign in GalleryItemOffers too?

USD

components/gallery/GalleryItem.vue Outdated Show resolved Hide resolved
components/shared/Avatar.vue Outdated Show resolved Hide resolved
@yangwao
Copy link
Member

yangwao commented Jan 3, 2023

good to go?

@exezbcz
Copy link
Member

exezbcz commented Jan 3, 2023

good to go?

Wait for me 😅

@yangwao
Copy link
Member

yangwao commented Jan 3, 2023

@exezbcz
Copy link
Member

exezbcz commented Jan 3, 2023

is this final versions or you'll still be working on it?

on thing is missing: image

  • active states, when you click on the button and the dropdown popups, the button should change itself to active state

active state of buttons seems to be still missing

@prachi00
Copy link
Member Author

prachi00 commented Jan 3, 2023

is this final versions or you'll still be working on it?
on thing is missing: image

  • active states, when you click on the button and the dropdown popups, the button should change itself to active state

active state of buttons seems to be still missing

@exezbcz @yangwao I am not sure how to give that yet, found nothing here https://oruga.io/components/dropdown.html
can we make a separate issue for this one?

@yangwao
Copy link
Member

yangwao commented Jan 4, 2023

found nothing here oruga.io/components/dropdown.html
can we make a separate issue for this one?

yes

@codeclimate
Copy link

codeclimate bot commented Jan 4, 2023

Code Climate has analyzed commit b03b5fd and detected 0 issues on this pull request.

View more on Code Climate.

@yangwao yangwao mentioned this pull request Jan 4, 2023
Closed
@yangwao
Copy link
Member

yangwao commented Jan 4, 2023

pay 50 usd

Some work was being done, yet we can move on

Reopen if there are some things are not being still done

@yangwao yangwao merged commit 38144d7 into main Jan 4, 2023
@yangwao yangwao deleted the feat-gallery-btn-changes branch January 4, 2023 16:01
@yangwao
Copy link
Member

yangwao commented Jan 4, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 24.1 USD/KSM ~ 2.075 $KSM
🧗 EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU
🔗 0x2dbaa2bfccff120ac697a8dda3b0c45f8659e97a1090cad5a19646fdc2f9e38b

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangwao yangwao yangwao left review comments

@roiLeo roiLeo roiLeo left review comments

@preschian preschian Awaiting requested review from preschian preschian is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
paid pull-request has been paid S-changes-requested-🤞 PR is almost good to go, just some fine tunning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gallery Redesign: Buttons and states in right section
4 participants
@prachi00 @exezbcz @yangwao @roiLeo