🐛 hover effect on wallet disconnect

[petersopko]

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

• Bugfix
• Feature
• Refactoring

Context

• Closes Hover effect missing on buttons at wallet dialog #4589
• Requires deployment <>

Before submitting pull request, please make sure:

• My contribution builds clean without any errors or warnings
• I've merged recent default branch -- main and I've no conflicts
• I've tried to respect high code quality standards
• I've didn't break any original functionality
• I've posted a screenshot of demonstrated change in this PR

Optional

• I've tested it at </bsx/collection>
• I've tested PR on mobile
• I've written unit tests 🧪
• I've found edge cases

Had issue bounty label?

• Fill up your KSM address: Payout

Community participation

• Are you at KodaDot Discord?

Screenshot 📸

• My fix has changed something on UI; a screenshot is best to understand changes for others.
  

[kodabot]

SUCCESS @petersopko PR for issue #4589 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

[netlify]

✅ Deploy Preview for koda-nuxt ready!

Name	Link
🔨 Latest commit	648be07
🔍 Latest deploy log	https://app.netlify.com/sites/koda-nuxt/deploys/63b6dff264f7600008443611
😎 Deploy Preview	https://deploy-preview-4590--koda-nuxt.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[roiLeo]

would it be possible to use NeoButton component instead?

[exezbcz]

change account button does not have hover effect in dark mode, can you check that as well?

[petersopko]

would it be possible to use NeoButton component instead?

okay

change account button does not have hover effect in dark mode, can you check that as well?

yes

[roiLeo]

Are you sure there is no css style left to remove?

Enregistrement.de.l.ecran.2023-01-05.a.8.46.44.AM.mov

[petersopko]

@roiLeo should be ok now, I've replaced the buttons related to connecting / disconnecting wallet with NeoButtons, if there are some specific differences regarding the size of buttons (connect is now slightly smaller I think), please let's move forward and follow up in the spirit of @yangwao newest discussion post

[roiLeo]

we might have wrong hover border-color on dark-mode inherited from .o-btn--connect-dropdown

otherwise code lgtm

[yangwao]

Conflicting files
libs/ui/src/components/NeoButton/NeoButton.vue

@petersopko 👀

[petersopko]

Conflicting files
libs/ui/src/components/NeoButton/NeoButton.vue

@petersopko 👀

🚀

[codeclimate]

Code Climate has analyzed commit 648be07 and detected 0 issues on this pull request.

View more on Code Climate.

[yangwao]

pay 30 usd

[petersopko]

pay 30 usd

this didn't work 😅

[yangwao]

😍 Perfect, I’ve sent the payout
💵 $30 @ 24.74 USD/KSM ~ 1.213 $KSM
🧗 FNyt7T1xdbhN7dagf7yGYCRJuE3R45VmTCE3tjzy1rKxa7y
🔗 0x65ae40bc7c86e4de127805017c7596a55a1902e7f0cb5da202185e56205af398

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues