refactor: Rework image serving gateways #4604
Conversation
|
SUCCESS @Jarsen136 PR for issue #4598 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime! |
✅ Deploy Preview for koda-nuxt ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
utils/ipfs.ts
Outdated
| return ipfsUrl.replace('ipfs://', `${resolveProvider(provider)}ipfs/`) | ||
| } | ||
|
|
||
| return sanitizeArweaveUrl(ipfsUrl, provider as ArweaveProviders) |
There was a problem hiding this comment.
Avoid too many return statements within this function.
There was a problem hiding this comment.
Usually, using multiple return would be necessary to enhance readability
ref: https://stackoverflow.com/questions/36707/should-a-function-have-only-one-return-statement
|
ouiii let's see |
There was a problem hiding this comment.
LGTM. at least most of the functions moved to utils 👍
how about this one? #4598 (comment) doable in the separate PR maybe?
yup |
|
99% of changes are about moving code to different files |
|
Code Climate has analyzed commit 7284969 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Yup, most about moving the code.
|
|
pay 50 usd |
|
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR Type
Bugfix
Feature
Refactoring
Now the ipfs provider config has been collected into
@/utils/config/ipfs.The utils function related to them has been moved to
@/utils/ipfsfromcomponents/rmrk/utils.tsThe fallback ipfs provider would point to
https://image.w.kodadot.xyz/.Context
Before submitting pull request, please make sure:
Optional
Had issue bounty label?
Community participation
Screenshot 📸