Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fetch image on explore collection #4653

Merged
merged 4 commits into from
Jan 12, 2023

Conversation

preschian
Copy link
Member

@preschian preschian commented Jan 10, 2023

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Screenshot 2023-01-10 at 19 01 18

@netlify
Copy link

netlify bot commented Jan 10, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 51fa52a
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63c019b2690fc60008cbb575
😎 Deploy Preview https://deploy-preview-4653--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodabot
Copy link
Collaborator

kodabot commented Jan 10, 2023

WARNING @preschian PR for issue #4651 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #4651

@preschian preschian marked this pull request as ready for review January 10, 2023 11:57
@preschian preschian requested a review from a team as a code owner January 10, 2023 11:57
@preschian preschian requested review from prachi00 and removed request for a team January 10, 2023 11:57
@preschian
Copy link
Member Author

preschian commented Jan 10, 2023

TIL: indexedDB will throw an error on firefox private mode. so functions that rely on indexedDB will have different behaviour than chrome

btw, is that ok if I remove prefetchPage() on that page? @Jarsen136 @roiLeo

@roiLeo
Copy link
Contributor

roiLeo commented Jan 10, 2023

TIL: indexedDB will throw an error on firefox private mode. so functions that rely on indexedDB will have different behaviour than chrome

Aight, this is only present in firefox private mode. Will we restrict all browsers only for this case?
Or we can try to migrate idb store to Vuex/Pinia

btw, is that ok if I remove prefetchPage() on that page? @Jarsen136 @roiLeo

isn't this used for infiniteScroll? it seems to me that this has been added to speed up images display

@preschian
Copy link
Member Author

Will we restrict all browsers only for this case?

hhmm, I am still not sure if should we restrict this case or not. or maybe we move to localStorage

isn't this used for infiniteScroll? it seems to me that this has been added to speed up images display

I thought that also, but it seems the response time is still the same. CMIIW

@Jarsen136
Copy link
Contributor

TIL: indexedDB will throw an error on firefox private mode. so functions that rely on indexedDB will have different behaviour than chrome

Aight, this is only present in firefox private mode. Will we restrict all browsers only for this case? Or we can try to migrate idb store to Vuex/Pinia

I would prefer to restrict the usage of indexedDB only on firefox browsers in this case.

btw, is that ok if I remove prefetchPage() on that page? @Jarsen136 @roiLeo

isn't this used for infiniteScroll? it seems to me that this has been added to speed up images display

Yup, we guess we should keep the prefetchPage there for the shortened loading time. How about disable the cache method only on firefox.

I thought that also, but it seems the response time is still the same. CMIIW

IMO It would prefetch the metadata in advance to reduce the waiting time. 🤔

@yangwao yangwao requested a review from vikiival January 11, 2023 09:43
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vikiival
Copy link
Member

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's go

@roiLeo roiLeo added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked labels Jan 12, 2023
@vikiival
Copy link
Member

pay 50 usd

@yangwao
Copy link
Member

yangwao commented Jan 12, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 27.49 USD/KSM ~ 1.819 $KSM
🧗 DY4SQF2iD456tH89aQtz5wv1EV3BbSW8wKKuMcwbmXaj1pM
🔗 0x6946cd8545b33906bc9f0251e875d87036c550fd5f5698ffd6bd044c4834ed57

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jan 12, 2023
@codeclimate
Copy link

codeclimate bot commented Jan 12, 2023

Code Climate has analyzed commit 51fa52a and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival vikiival merged commit 7c5e3de into main Jan 12, 2023
@vikiival vikiival deleted the fix/get-images-on-explorer-collection branch January 12, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gallery images don't load in Firefox Private mode
6 participants