-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fetch image on explore collection #4653
Conversation
✅ Deploy Preview for koda-nuxt ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
WARNING @preschian PR for issue #4651 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #4651 |
TIL: indexedDB will throw an error on firefox private mode. so functions that rely on indexedDB will have different behaviour than chrome
btw, is that ok if I remove |
Aight, this is only present in firefox private mode. Will we restrict all browsers only for this case?
isn't this used for infiniteScroll? it seems to me that this has been added to speed up images display |
hhmm, I am still not sure if should we restrict this case or not. or maybe we move to localStorage
I thought that also, but it seems the response time is still the same. CMIIW |
I would prefer to restrict the usage of indexedDB only on firefox browsers in this case.
Yup, we guess we should keep the
IMO It would prefetch the metadata in advance to reduce the waiting time. 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's go
pay 50 usd |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
Code Climate has analyzed commit 51fa52a and detected 0 issues on this pull request. View more on Code Climate. |
Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR Type
Context
Before submitting pull request, please make sure:
Optional
Had issue bounty label?
Community participation
Screenshot 📸