Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reactive identity #4694

Merged
merged 1 commit into from
Jan 14, 2023
Merged

fix: reactive identity #4694

merged 1 commit into from
Jan 14, 2023

Conversation

preschian
Copy link
Member

@preschian preschian commented Jan 14, 2023

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Screenshot 2023-01-14 at 13 16 57

@kodabot
Copy link
Collaborator

kodabot commented Jan 14, 2023

WARNING @preschian PR for issue #4693 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #4693

@netlify
Copy link

netlify bot commented Jan 14, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 8d70100
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63c246fe8d27f000087a79a3
😎 Deploy Preview https://deploy-preview-4694--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented Jan 14, 2023

Code Climate has analyzed commit 8d70100 and detected 0 issues on this pull request.

View more on Code Climate.

@preschian
Copy link
Member Author

preschian commented Jan 14, 2023

@preschian preschian marked this pull request as ready for review January 14, 2023 06:15
@preschian preschian requested a review from a team as a code owner January 14, 2023 06:15
@preschian preschian requested review from Jarsen136 and prachi00 and removed request for a team January 14, 2023 06:15
@Jarsen136
Copy link
Contributor

how to reproduce, open the link in incognito:

Wired, I still could not reproduce it in incognito mode on the beta env. Is it related to the cache?
image

@preschian
Copy link
Member Author

preschian commented Jan 14, 2023

how to reproduce, open the link in incognito:

Wired, I still could not reproduce it in incognito mode on the beta env. Is it related to the cache?

maybe try with bsx one https://beta.kodadot.xyz/bsx/gallery/3579963603-29?redesign=true

Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works. code lgtm

@Jarsen136 Jarsen136 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Jan 14, 2023
@yangwao
Copy link
Member

yangwao commented Jan 14, 2023

yes I've noticed on bsx, not on rmrk, which is strange

@yangwao
Copy link
Member

yangwao commented Jan 14, 2023

pay 50 usd

@yangwao yangwao merged commit d9c02f1 into main Jan 14, 2023
@yangwao yangwao deleted the fix/reactive-identity branch January 14, 2023 07:14
@yangwao
Copy link
Member

yangwao commented Jan 14, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 32.22 USD/KSM ~ 1.552 $KSM
🧗 DY4SQF2iD456tH89aQtz5wv1EV3BbSW8wKKuMcwbmXaj1pM
🔗 0xd279d5d44b178d4e6511ead4fd5f30393cbcad5755fca93b1330e13a45b88b3a

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Creator and Owner on item
4 participants