Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4478 spacing issue fix #4706

Merged
merged 6 commits into from
Jan 19, 2023
Merged

#4478 spacing issue fix #4706

merged 6 commits into from
Jan 19, 2023

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented Jan 15, 2023 •
edited

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address:
    Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
    Screen Shot 2023-01-14 at 4 00 20 PM

@prachi00 prachi00 requested a review from a team as a code owner January 15, 2023 00:00
@prachi00 prachi00 requested review from vikiival and Jarsen136 and removed request for a team January 15, 2023 00:00
@kodabot
Copy link
Collaborator

kodabot commented Jan 15, 2023

WARNING @prachi00 PR for issue #4478 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #4478

@netlify
Copy link

netlify bot commented Jan 15, 2023 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit a37d9a4
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63c83bbdc4720c00099fb8c8
😎 Deploy Preview https://deploy-preview-4706--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Jarsen136
Jarsen136 reviewed Jan 15, 2023
View reviewed changes
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess there are a little style conflict between this PR and #4697. May wait for #4697 to merged first, and then we could do some small adjustment here, to check spacing on mobile and pc.

components/gallery/GalleryItem.vue Outdated
@@ -161,6 +165,11 @@ useNuxt2Meta({
font-size: 2.4375em;
}

hr {
height: 1px;
margin: 60px 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

classnamemy-x may help

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think my-x is a class?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think my-x is a class?

cf Bulma doc example: my-5
please don't overload hr elements

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roiLeo my-5 is still not enough spacing to match what we have in figma

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are you trying to fix here?
Instead of adding margin to hr try to add spacing on element around the component

components/gallery/GalleryItemAction/GalleryItemActionSection.vue Outdated Show resolved Hide resolved
components/gallery/GalleryItem.vue Outdated Show resolved Hide resolved
@exezbcz
Copy link
Member

exezbcz commented Jan 15, 2023

what about this gap?
image
should be same as the gap between cards i think.

@prachi00
Copy link
Member Author

what about this gap? image should be same as the gap between cards i think.

it is the same

@exezbcz
Copy link
Member

exezbcz commented Jan 16, 2023

what about this gap? image should be same as the gap between cards i think.

it is the same

I mean the gap between the top and bottom part

vikiival
vikiival previously requested changes Jan 16, 2023
View reviewed changes
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Issues were pointed out by @Jarsen136.

@exezbcz
Copy link
Member

exezbcz commented Jan 17, 2023

image
Still does not look like its the same.

@roiLeo
Copy link
Contributor

roiLeo commented Jan 17, 2023 •
edited

Still does not look like its the same.

Can you show us the desired outcome?

@exezbcz
Copy link
Member

exezbcz commented Jan 17, 2023 •
edited

Still does not look like its the same.

Can you show us the desired outcome?

yesss, sorry for that
image
should look like this, its not symmetrical, thats what is the issue :D
the red box is square.

roiLeo
roiLeo previously requested changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please don't add spacing directly on column div? (bad pratice)

you may need to use variable-gap or change spacing inside column content

@Jarsen136
Copy link
Contributor

I guess there are a little style conflict between this PR and #4697. May wait for #4697 to merged first, and then we could do some small adjustment here, to check spacing on mobile and pc.

Merged. Let's resolve some code conflicts.

@yangwao yangwao mentioned this pull request Jan 17, 2023
Closed
@prachi00
Copy link
Member Author

@exezbcz
Screen Shot 2023-01-17 at 10 32 33 AM

@roiLeo roiLeo removed their request for review January 18, 2023 07:23
@exezbcz
Copy link
Member

exezbcz commented Jan 18, 2023

good job

@codeclimate
Copy link

codeclimate bot commented Jan 18, 2023

Code Climate has analyzed commit a37d9a4 and detected 0 issues on this pull request.

View more on Code Climate.

@yangwao
Copy link
Member

yangwao commented Jan 19, 2023

pay 20 usd

@yangwao yangwao closed this Jan 19, 2023
@yangwao yangwao reopened this Jan 19, 2023
@yangwao
Copy link
Member

yangwao commented Jan 19, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 34.66 USD/KSM ~ 0.577 $KSM
🧗 EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU
🔗 0x03ce0bc481ea0f9bf87283d902a9f042f40e6588b2a4f4446fe9edcd5de1239a

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao merged commit 346f5e4 into main Jan 19, 2023
@yangwao yangwao added the paid pull-request has been paid label Jan 19, 2023
@yangwao yangwao deleted the feat-gallery-spacing branch January 19, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo left review comments

@vikiival vikiival vikiival left review comments

@Jarsen136 Jarsen136 Awaiting requested review from Jarsen136

Assignees
No one assigned
Labels
paid pull-request has been paid S-visual-ok-✅
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Galery item prelaunch feedback v1
7 participants
@prachi00 @kodabot @exezbcz @roiLeo @Jarsen136 @yangwao @vikiival