Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 IdentityItem spacing issue #4717

Merged
merged 1 commit into from
Jan 16, 2023
Merged

🔧 IdentityItem spacing issue #4717

merged 1 commit into from
Jan 16, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Jan 16, 2023

PR Type

  • Bugfix

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Screenshot 📸

before
Screenshot 2023-01-16 at 10-57-50 Fancy cat KodaDot - Kusama NFT Market Explorer

after
Screenshot 2023-01-16 at 11-37-02 Fancy cat KodaDot - Kusama NFT Market Explorer

@roiLeo roiLeo requested a review from a team as a code owner January 16, 2023 10:38
@roiLeo roiLeo requested review from preschian and Jarsen136 and removed request for a team January 16, 2023 10:38
@netlify
Copy link

netlify bot commented Jan 16, 2023 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 7b0b95e
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63c5292bee99870009a1f277
😎 Deploy Preview https://deploy-preview-4717--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented Jan 16, 2023

Code Climate has analyzed commit 7b0b95e and detected 0 issues on this pull request.

View more on Code Climate.

Jarsen136
Jarsen136 approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@Jarsen136 Jarsen136 added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked labels Jan 16, 2023
@roiLeo roiLeo merged commit a765c1a into kodadot:main Jan 16, 2023
@roiLeo roiLeo deleted the fix/Identity/spacing branch January 16, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian approved these changes

@Jarsen136 Jarsen136 Jarsen136 approved these changes

Assignees
No one assigned
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@roiLeo @preschian @Jarsen136