Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: i18n config cache on vuex #4728

Merged
merged 3 commits into from
Jan 17, 2023
Merged

fix: i18n config cache on vuex #4728

merged 3 commits into from
Jan 17, 2023

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@Jarsen136 Jarsen136 requested a review from a team as a code owner January 17, 2023 02:10
@Jarsen136 Jarsen136 requested review from preschian and vikiival and removed request for a team January 17, 2023 02:10
@kodabot
Copy link
Collaborator

kodabot commented Jan 17, 2023

SUCCESS @Jarsen136 PR for issue #4727 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Jan 17, 2023 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 5d54022
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63c65db3a538530010d05a3b
😎 Deploy Preview https://deploy-preview-4728--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Jarsen136 Jarsen136 mentioned this pull request Jan 17, 2023
Closed
vikiival
vikiival reviewed Jan 17, 2023
View reviewed changes
utils/config/i18n.ts Outdated Show resolved Hide resolved
utils/config/i18n.ts Outdated
export const getLangsFlags = () => langsFlags

export const getUserFlag = (userLang: string) =>
langsFlags.find((lang) => lang.value === userLang)?.flag || langsFlags[0].flag
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why also flag?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think getUserFlag could stay in its original place.

@codeclimate
Copy link

codeclimate bot commented Jan 17, 2023

Code Climate has analyzed commit 5d54022 and detected 0 issues on this pull request.

View more on Code Climate.

@yangwao
Copy link
Member

yangwao commented Jan 17, 2023

pay 50 usd

let's try if it updates my instance on beta with new stuff

@yangwao yangwao merged commit e0cff25 into kodadot:main Jan 17, 2023
@yangwao
Copy link
Member

yangwao commented Jan 17, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 34.25 USD/KSM ~ 1.46 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0x3c6f96278ed155d86d0196f59d5e204b6066c72b12b425649f3ee8ee07f38875

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added paid pull-request has been paid and removed paid pull-request has been paid labels Jan 17, 2023
@yangwao
Copy link
Member

yangwao commented Jan 18, 2023

pay 50

@yangwao
Copy link
Member

yangwao commented Jan 18, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 35.12 USD/KSM ~ 1.424 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0xe76f4575c5d23b9792ecc424b7349215c2997ce7944b9a43add3355a1c7a245d

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jan 18, 2023
@yangwao yangwao mentioned this pull request Jan 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian Awaiting requested review from preschian preschian is a code owner automatically assigned from kodadot/code-review-guild

@vikiival vikiival Awaiting requested review from vikiival

Assignees
No one assigned
Labels
paid pull-request has been paid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

service worker / pwa fetch new update doesn't show up
4 participants
@Jarsen136 @kodabot @yangwao @vikiival