Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change description of SEO Cards #4737

Merged
merged 8 commits into from
Jan 17, 2023
Merged

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@kodabot
Copy link
Collaborator

kodabot commented Jan 17, 2023

WARNING @Jarsen136 PR for issue #4732 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #4732

@netlify
Copy link

netlify bot commented Jan 17, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 1f22228
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63c6bcab74bf340008dfea4f
😎 Deploy Preview https://deploy-preview-4737--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Jarsen136
Copy link
Contributor Author

@Jarsen136 Jarsen136 marked this pull request as ready for review January 17, 2023 14:36
@Jarsen136 Jarsen136 requested a review from a team as a code owner January 17, 2023 14:36
@Jarsen136 Jarsen136 requested review from roiLeo and vikiival and removed request for a team January 17, 2023 14:36
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@yangwao
Copy link
Member

yangwao commented Jan 17, 2023

Grammar n*** has bumped to me

@Jarsen136 can you change it pls to 🥹

"One Stop NFT Shop on Polkadot"

@codeclimate
Copy link

codeclimate bot commented Jan 17, 2023

Code Climate has analyzed commit 1f22228 and detected 0 issues on this pull request.

View more on Code Climate.

@Jarsen136
Copy link
Contributor Author

Grammar n*** has bumped to me

@Jarsen136 can you change it pls to 🥹

"One Stop NFT Shop on Polkadot"

✅ Done

@vikiival
Copy link
Member

pay 20 usd

@yangwao
Copy link
Member

yangwao commented Jan 17, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 36.44 USD/KSM ~ 0.549 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0x5dc94374b8519364bccd99d2832e173f3ab06c021f5dad6d6ba8666a2086e032

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jan 17, 2023
@vikiival vikiival merged commit 6d912f4 into kodadot:main Jan 17, 2023
@yangwao yangwao removed the paid pull-request has been paid label Jan 18, 2023
@yangwao
Copy link
Member

yangwao commented Jan 18, 2023

pay 20

@yangwao
Copy link
Member

yangwao commented Jan 18, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 34.98 USD/KSM ~ 0.572 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0x2c71520008eb7cff7ad4f8c12aef79b5437358d855a7aabeb1c003fda4717bb8

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change description of SEO Cards
5 participants