Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Description more important than Properties #4738

Merged
merged 1 commit into from
Jan 17, 2023
Merged

fix: Description more important than Properties #4738

merged 1 commit into from
Jan 17, 2023

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Jan 17, 2023 •
edited
Loading

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

@Jarsen136 Jarsen136 requested a review from a team as a code owner January 17, 2023 13:26
@Jarsen136 Jarsen136 requested review from preschian and vikiival and removed request for a team January 17, 2023 13:26
@kodabot
Copy link
Collaborator

kodabot commented Jan 17, 2023

WARNING @Jarsen136 PR for issue #4734 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #4734

@netlify
Copy link

netlify bot commented Jan 17, 2023 •
edited
Loading

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit d24432a
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63c6a20beaf35900089072b3
😎 Deploy Preview https://deploy-preview-4738--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented Jan 17, 2023

Code Climate has analyzed commit d24432a and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival
Copy link
Member

Screenshot 2023-01-17 at 14 35 11

vikiival
vikiival approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vikiival
Copy link
Member

pay 20 usd

@vikiival vikiival merged commit cb6eda6 into kodadot:main Jan 17, 2023
@yangwao
Copy link
Member

yangwao commented Jan 17, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 35.17 USD/KSM ~ 0.569 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0xc01b730b80b9218f5890c49ad52487982f2c9b7f1164de9289886486840b802b

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added paid pull-request has been paid and removed paid pull-request has been paid labels Jan 17, 2023
@yangwao
Copy link
Member

yangwao commented Jan 18, 2023

pay 20

@yangwao
Copy link
Member

yangwao commented Jan 18, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 35.11 USD/KSM ~ 0.57 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0xeeb41b90452f5cfdcbe55f5d1cbf35278be723a7a96ad9d659af82aae339ebe2

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jan 18, 2023
@yangwao yangwao mentioned this pull request Jan 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival vikiival approved these changes

@preschian preschian Awaiting requested review from preschian preschian is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
paid pull-request has been paid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gallery item redesign: Description more important than Properties.
4 participants
@Jarsen136 @kodabot @vikiival @yangwao