Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 bsx/snek inactive offers #4739

Merged
merged 5 commits into from
Jan 19, 2023
Merged

🔧 bsx/snek inactive offers #4739

merged 5 commits into from
Jan 19, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Jan 17, 2023

tested on /snek/gallery/914494658-1?redesign=true

PR Type

  • Bugfix

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Had issue bounty label?

  • Fill up your KSM address: Payout

Screenshot 📸

Screenshot 2023-01-17 at 15-45-49 Fancy cat KodaDot - Kusama NFT Market Explorer

@roiLeo roiLeo requested a review from a team as a code owner January 17, 2023 14:50
@roiLeo roiLeo requested review from preschian and Jarsen136 and removed request for a team January 17, 2023 14:50
@netlify
Copy link

netlify bot commented Jan 17, 2023 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 9e6ffb9
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63c7fcbc494caa00094c4066
😎 Deploy Preview https://deploy-preview-4739--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Jarsen136
Jarsen136 reviewed Jan 18, 2023
View reviewed changes
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it's correct to change the status of expired offer in the client side tbh. Shouldn't we solve this issue in indexer side ?

@roiLeo
Copy link
Contributor Author

roiLeo commented Jan 18, 2023

I'm not sure if it's correct to change the status of expired offer in the client side tbh. Shouldn't we solve this issue in indexer side ?

Yes! link kodadot/snek#13 but can't do it right now so I've made this hotfix

@Jarsen136
Copy link
Contributor

Jarsen136 commented Jan 18, 2023 •
edited

I'm not sure if it's correct to change the status of expired offer in the client side tbh. Shouldn't we solve this issue in indexer side ?

Yes! link kodadot/snek#13 but can't do it right now so I've made this hotfix

Got it. Then it's good to go for now.

Jarsen136
Jarsen136 approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

Jarsen136
Jarsen136 reviewed Jan 18, 2023
View reviewed changes
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few comment

components/gallery/GalleryItemAction/GalleryItemActionType/GalleryItemOffer.vue Show resolved Hide resolved
components/gallery/GalleryItemTabsPanel/GalleryItemOffers.vue Outdated Show resolved Hide resolved
@roiLeo roiLeo mentioned this pull request Jan 18, 2023
Merged
18 tasks
@codeclimate
Copy link

codeclimate bot commented Jan 18, 2023

Code Climate has analyzed commit 9e6ffb9 and detected 0 issues on this pull request.

View more on Code Climate.

@yangwao
Copy link
Member

yangwao commented Jan 19, 2023

pay 50 usd

@yangwao yangwao merged commit 2b536f5 into kodadot:main Jan 19, 2023
@yangwao yangwao added the A-basilisk issues related to basilisk parachain label Jan 19, 2023
@yangwao
Copy link
Member

yangwao commented Jan 19, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 34.66 USD/KSM ~ 1.443 $KSM
🧗 HguGafrfk8nRP9a4tgJf7hLvSSFie8GtkDjyWFHQ2kDUAMc
🔗 0x674f8781ca5b9a8f0305ee55e556c2356b69338eec55aef9988b8ed36d5c402a

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian approved these changes

@Jarsen136 Jarsen136 Jarsen136 approved these changes

Assignees
No one assigned
Labels
A-basilisk issues related to basilisk parachain paid pull-request has been paid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Offer is still in active status though it has expired long time ago
4 participants
@roiLeo @Jarsen136 @yangwao @preschian