Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Wrap markdown in description #4743

Merged
merged 3 commits into from
Jan 18, 2023
Merged

fix: Wrap markdown in description #4743

merged 3 commits into from
Jan 18, 2023

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

@Jarsen136 Jarsen136 requested a review from a team as a code owner January 17, 2023 15:36
@Jarsen136 Jarsen136 requested review from preschian and roiLeo and removed request for a team January 17, 2023 15:36
@kodabot
Copy link
Collaborator

kodabot commented Jan 17, 2023

SUCCESS @Jarsen136 PR for issue #4731 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Jan 17, 2023 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit f7bc09c
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63c7799e9bcf7f0008f93cc0
😎 Deploy Preview https://deploy-preview-4743--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Jarsen136
Copy link
Contributor Author

Feel free to drop some design suggestions for the markdown section. @exezbcz

I found that the scrolling part in the original issue is code type, which means we could not make the text wrap to the next line

image

ref: http://miaolz123.github.io/vue-markdown/

roiLeo
roiLeo reviewed Jan 17, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried white-space: pre-wrap;?

@Jarsen136
Copy link
Contributor Author

Jarsen136 commented Jan 17, 2023 •
edited

Have you tried white-space: pre-wrap;?

👍 That's really cool. It works now and the code section would not be scrollable on the horizon.
image

@yangwao yangwao mentioned this pull request Jan 17, 2023
Closed
@preschian preschian added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Jan 18, 2023
@codeclimate
Copy link

codeclimate bot commented Jan 18, 2023

Code Climate has analyzed commit f7bc09c and detected 0 issues on this pull request.

View more on Code Climate.

roiLeo
roiLeo approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ wfm

@roiLeo roiLeo added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jan 18, 2023
@yangwao
Copy link
Member

yangwao commented Jan 18, 2023

pay 50 usd

@yangwao yangwao merged commit 6cb5a88 into kodadot:main Jan 18, 2023
@yangwao
Copy link
Member

yangwao commented Jan 18, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 34.88 USD/KSM ~ 1.433 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0x18ca7061a23d2eb453cd5b4acc2ceeecf21fc71535c71a606dbf9055c190ecd7

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added paid pull-request has been paid and removed paid pull-request has been paid labels Jan 18, 2023
@yangwao
Copy link
Member

yangwao commented Jan 18, 2023

pay 50

@yangwao
Copy link
Member

yangwao commented Jan 18, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 35.11 USD/KSM ~ 1.424 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0xfbd0ed7632ba7fda2abbe6b48e596990af1ea8ffe93fe5c04639ca5d86356983

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jan 18, 2023
@yangwao yangwao mentioned this pull request Jan 18, 2023
Closed
@exezbcz
Copy link
Member

exezbcz commented Jan 18, 2023

nvm, looks good, i would only change the border color to k-grey or something with less contrast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian approved these changes

@roiLeo roiLeo roiLeo approved these changes

Assignees
No one assigned
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrap markdown in description
6 participants
@Jarsen136 @kodabot @yangwao @exezbcz @preschian @roiLeo