Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4763 gallery fixes #4766

Merged
merged 4 commits into from
Jan 21, 2023
Merged

#4763 gallery fixes #4766

merged 4 commits into from
Jan 21, 2023

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented Jan 19, 2023 •
edited

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address:
    Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
    Screen Shot 2023-01-18 at 7 30 37 PM

@prachi00 prachi00 requested a review from a team as a code owner January 19, 2023 03:32
@prachi00 prachi00 requested review from roiLeo and vikiival and removed request for a team January 19, 2023 03:32
@netlify
Copy link

netlify bot commented Jan 19, 2023 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 76c2452
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63ca022071f857000859322e
😎 Deploy Preview https://deploy-preview-4766--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

roiLeo
roiLeo reviewed Jan 19, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-01-19 at 16-47-11 🌑 Dark side KodaDot - NFT Market Explorer

buttons (action slide) design should be unified, it miss new padding on "Transfer"

@exezbcz
Copy link
Member

exezbcz commented Jan 19, 2023

missing padding, otherwise ok

i guess this is connected with the full width action buttons?
image

@prachi00
Copy link
Member Author

fixed

@codeclimate
Copy link

codeclimate bot commented Jan 20, 2023

Code Climate has analyzed commit 76c2452 and detected 0 issues on this pull request.

View more on Code Climate.

@exezbcz
Copy link
Member

exezbcz commented Jan 20, 2023

i guess this is for another issue?
image

@yangwao
Copy link
Member

yangwao commented Jan 20, 2023

i guess this is for another issue?

yes

@vikiival vikiival mentioned this pull request Jan 21, 2023
Closed
@vikiival vikiival merged commit 2cc2711 into main Jan 21, 2023
@vikiival vikiival deleted the feat-gallery-fixes branch January 21, 2023 13:24
@vikiival
Copy link
Member

pay 10 usd

@yangwao
Copy link
Member

yangwao commented Jan 21, 2023

😍 Perfect, I’ve sent the payout
💵 $10 @ 35.4 USD/KSM ~ 0.282 $KSM
🧗 EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU
🔗 0x5ad471623e7888e21be2adf2d02bcaaee1fa3935b6dd05984c8695b9467510ac

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo left review comments

@vikiival vikiival Awaiting requested review from vikiival vikiival is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
paid pull-request has been paid S-visual-ok-✅
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Owner gallery item ui
5 participants
@prachi00 @exezbcz @yangwao @vikiival @roiLeo