Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4761 color identity mobile #4767

Merged
merged 2 commits into from
Jan 19, 2023
Merged

#4761 color identity mobile #4767

merged 2 commits into from
Jan 19, 2023

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented Jan 19, 2023

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
    Screen Shot 2023-01-18 at 7 45 33 PM

@prachi00 prachi00 requested a review from a team as a code owner January 19, 2023 03:46
@prachi00 prachi00 requested review from preschian and Jarsen136 and removed request for a team January 19, 2023 03:46
@netlify
Copy link

netlify bot commented Jan 19, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit bdb83c8
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63c8c266e995000008a2aea8
😎 Deploy Preview https://deploy-preview-4767--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodabot
Copy link
Collaborator

kodabot commented Jan 19, 2023

SUCCESS @prachi00 PR for issue #4761 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be a boolean config props instead of removing functionality in the IdentityLink component.

@prachi00
Copy link
Member Author

IdentityLink

the component is not being used anywhere else right now, but okay yes it would be nice to have it for future

@prachi00
Copy link
Member Author

IdentityLink

the component is not being used anywhere else right now, but okay yes it would be nice to have it for future

done

@codeclimate
Copy link

codeclimate bot commented Jan 19, 2023

Code Climate has analyzed commit bdb83c8 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@Jarsen136 Jarsen136 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Jan 19, 2023
@yangwao
Copy link
Member

yangwao commented Jan 19, 2023

pay 30

@yangwao yangwao merged commit f536157 into main Jan 19, 2023
@yangwao yangwao deleted the feat-identity-color-mobile branch January 19, 2023 20:53
@yangwao
Copy link
Member

yangwao commented Jan 19, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 34.29 USD/KSM ~ 0.875 $KSM
🧗 EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU
🔗 0x5ddbdcf7cddcc8995e18ce54c68d525a47b4a6af07fc724308335f079c4f9f73

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-visual-ok-✅
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile creator and owner links
6 participants