Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missing collection link #4783

Merged
merged 2 commits into from
Jan 20, 2023
Merged

fix: Missing collection link #4783

merged 2 commits into from
Jan 20, 2023

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

@Jarsen136 Jarsen136 requested a review from a team as a code owner January 20, 2023 15:06
@Jarsen136 Jarsen136 requested review from preschian and roiLeo and removed request for a team January 20, 2023 15:06
@kodabot
Copy link
Collaborator

kodabot commented Jan 20, 2023

SUCCESS @Jarsen136 PR for issue #4781 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Jan 20, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 4f0e1b5
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63cab18f6c939900080d67c2
😎 Deploy Preview https://deploy-preview-4783--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Jarsen136
Copy link
Contributor Author

For now, I would use the id of item as its name if the data is empty.

image

The missing name should be solved on the indexer side. related to #4775

Copy link
Member

@preschian preschian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fallback meta title also?

otherwise LGTM

@yangwao
Copy link
Member

yangwao commented Jan 20, 2023

For now, I would use the id of item as its name if the data is empty.

image The missing name should be solved on the indexer side. related to #4775

means indexer failed to fetch metadata?

cc @vikiival

@Jarsen136
Copy link
Contributor Author

The missing name should be solved on the indexer side. related to #4775

means indexer failed to fetch?

Yes, I think so.

@yangwao
Copy link
Member

yangwao commented Jan 20, 2023

pay 30 usd

@yangwao
Copy link
Member

yangwao commented Jan 20, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 34.25 USD/KSM ~ 0.876 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0x0920a835c00b7546e7b3bab371a5c4295df5cec9a558b5029a509370b43353e3

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jan 20, 2023
@yangwao yangwao mentioned this pull request Jan 20, 2023
1 task
@Jarsen136
Copy link
Contributor Author

Jarsen136 commented Jan 20, 2023

fallback meta title also?

added!

@codeclimate
Copy link

codeclimate bot commented Jan 20, 2023

Code Climate has analyzed commit 4f0e1b5 and detected 0 issues on this pull request.

View more on Code Climate.

@yangwao yangwao merged commit 6c90281 into kodadot:main Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing collection link?
4 participants