Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix full width button #4795

Merged
merged 8 commits into from
Jan 24, 2023

Conversation

petersopko
Copy link
Contributor

@petersopko petersopko commented Jan 21, 2023

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
    image

@petersopko petersopko requested a review from a team as a code owner January 21, 2023 13:22
@petersopko petersopko requested review from roiLeo and Jarsen136 and removed request for a team January 21, 2023 13:22
@kodabot
Copy link
Collaborator

kodabot commented Jan 21, 2023

SUCCESS @petersopko PR for issue #4776 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Jan 21, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 394c337
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63cdaed3516f100008adfe95
😎 Deploy Preview https://deploy-preview-4795--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@petersopko petersopko changed the title 🐛 fix full width button + replace invalid variable on align content 🐛 fix full width button Jan 21, 2023
@petersopko petersopko marked this pull request as draft January 21, 2023 14:29
@petersopko
Copy link
Contributor Author

connected to:

tbc
image

@roiLeo
Copy link
Contributor

roiLeo commented Jan 22, 2023

Have you tried to add expanded prop in this Buton component? It might work as excepted

@petersopko
Copy link
Contributor Author

Have you tried to add expanded prop in this Buton component? It might work as excepted

I haven't, but I will. I'll get back to this in the evening.

@codeclimate
Copy link

codeclimate bot commented Jan 22, 2023

Code Climate has analyzed commit 394c337 and detected 0 issues on this pull request.

View more on Code Climate.

@petersopko petersopko marked this pull request as ready for review January 22, 2023 21:47
@petersopko
Copy link
Contributor Author

passing on #4785 due to time constraint (I didn't figure out good enough solution in time), let's move on with

if the code looks ok.

Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@Jarsen136 Jarsen136 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Jan 23, 2023
@yangwao
Copy link
Member

yangwao commented Jan 24, 2023

pay 30 usd

@yangwao yangwao merged commit a16f6d3 into kodadot:main Jan 24, 2023
@yangwao
Copy link
Member

yangwao commented Jan 24, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 35.92 USD/KSM ~ 0.835 $KSM
🧗 FNyt7T1xdbhN7dagf7yGYCRJuE3R45VmTCE3tjzy1rKxa7y
🔗 0x3c26399a0c91427312c1d65b347fb83fee346313920032c94c343c259e8201cc

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-visual-ok-✅
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full width button fix
6 participants