-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove IDB
on carousel
#4797
Conversation
✅ Deploy Preview for koda-nuxt ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
IDB
on carousel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you're removing idb cache on carousel, are we going to experience some loading (Time) issue from user perspective ? Otherwise wfm
From what @preschian claimed, it will be now managed by service worker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please clarify the loading times.
OTHERWISE LGTM
WebSocket (on identity) and graphql queries are not handled by service workers. it means the user will take loading time based on graphql response time the related issue regarding response time with graphql set filter |
Code Climate has analyzed commit a7621d8 and detected 0 issues on this pull request. View more on Code Climate. |
Let it roll. |
Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR Type
Context