Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove IDB on carousel #4797

Merged
merged 2 commits into from
Jan 25, 2023
Merged

Conversation

preschian
Copy link
Member

@preschian preschian commented Jan 21, 2023

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

@netlify
Copy link

netlify bot commented Jan 21, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit a7621d8
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63d108456934c60009a5a1b9
😎 Deploy Preview https://deploy-preview-4797--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@preschian preschian marked this pull request as ready for review January 21, 2023 13:57
@preschian preschian requested a review from a team as a code owner January 21, 2023 13:57
@preschian preschian requested review from roiLeo, Jarsen136 and vikiival and removed request for a team January 21, 2023 13:57
@preschian preschian changed the title refactor: remove idb on carousel refactor: remove IDB on carousel Jan 21, 2023
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you're removing idb cache on carousel, are we going to experience some loading (Time) issue from user perspective ? Otherwise wfm

@vikiival
Copy link
Member

Since you're removing idb cache on carousel, are we going to experience some loading (Time) issue from user perspective ? Otherwise wfm

From what @preschian claimed, it will be now managed by service worker

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clarify the loading times.

OTHERWISE LGTM

@preschian
Copy link
Member Author

Since you're removing idb cache on carousel, are we going to experience some loading (Time) issue from user perspective ?

it will be now managed by service worker

WebSocket (on identity) and graphql queries are not handled by service workers. it means the user will take loading time based on graphql response time

the related issue regarding response time with graphql

set filter is:service-worker-intercepted under the Network tab to see what assets through service workers

Screenshot 2023-01-23 at 15 23 27

@codeclimate
Copy link

codeclimate bot commented Jan 25, 2023

Code Climate has analyzed commit a7621d8 and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival
Copy link
Member

Let it roll.
It thought that I merged it🙈

@vikiival vikiival merged commit e152329 into main Jan 25, 2023
@vikiival vikiival deleted the refactor/remove-idb-on-carousel branch January 25, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants