Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 show own offer #4808

Merged
merged 4 commits into from
Jan 23, 2023
Merged

🔧 show own offer #4808

merged 4 commits into from
Jan 23, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Jan 23, 2023 •
edited

PR Type

  • Bugfi

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Screenshot 📸

Screenshot 2023-01-23 at 11-57-47 Shader 003 KodaDot - NFT Market Explorer

TODO

  • missing highest offer when own offer

@roiLeo roiLeo requested a review from a team as a code owner January 23, 2023 10:46
@roiLeo roiLeo requested review from vikiival and Jarsen136 and removed request for a team January 23, 2023 10:46
@netlify
Copy link

netlify bot commented Jan 23, 2023 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 937ba82
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63ce68448611550009604fab
😎 Deploy Preview https://deploy-preview-4808--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented Jan 23, 2023

Code Climate has analyzed commit 937ba82 and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival vikiival merged commit 37e37f7 into kodadot:main Jan 23, 2023
@roiLeo roiLeo deleted the fix/offers/account branch January 23, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival vikiival approved these changes

@Jarsen136 Jarsen136 Awaiting requested review from Jarsen136 Jarsen136 is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

missing own offer in "Offers" tab
2 participants
@roiLeo @vikiival