Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing BURN event in GalleryItem Activity tab #4809

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

/snek/gallery/331660682-4

image

@Jarsen136 Jarsen136 requested a review from a team as a code owner January 23, 2023 10:55
@Jarsen136 Jarsen136 requested review from preschian and roiLeo and removed request for a team January 23, 2023 10:55
@kodabot
Copy link
Collaborator

kodabot commented Jan 23, 2023

SUCCESS @Jarsen136 PR for issue #4805 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Jan 23, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 575a5e0
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63ce67983f3fd800097701f1
😎 Deploy Preview https://deploy-preview-4809--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented Jan 23, 2023

Code Climate has analyzed commit 575a5e0 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • CONSUME on rmrk
  • BURN on bsx/snek

edit: nvm...

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ code lgtm & wfm 331660682-4

still missing UI for burned item (ref #4612)

@vikiival vikiival merged commit bef6391 into kodadot:main Jan 23, 2023
@vikiival
Copy link
Member

  • CONSUME on rmrk
  • BURN on bsx/snek

edit: nvm...

It will be unified with RMRKv2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing BURN event in GalleryItem Activity tab
4 participants