Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4804 fixed using theme #4812

Merged
merged 2 commits into from
Jan 27, 2023
Merged

#4804 fixed using theme #4812

merged 2 commits into from
Jan 27, 2023

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented Jan 24, 2023 •
edited

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address:
    Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@prachi00 prachi00 requested a review from a team as a code owner January 24, 2023 03:42
@prachi00 prachi00 requested review from roiLeo and Jarsen136 and removed request for a team January 24, 2023 03:42
@netlify
Copy link

netlify bot commented Jan 24, 2023 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 8011ea0
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63d341ee7f408c0009e88f35
😎 Deploy Preview https://deploy-preview-4812--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodabot
Copy link
Collaborator

kodabot commented Jan 24, 2023

WARNING @prachi00 PR for issue #4804 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #4804

roiLeo
roiLeo approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to create a scss file for this component
Otherwise ✅ wfm

styles/abstracts/_variables.scss Show resolved Hide resolved
@yangwao yangwao mentioned this pull request Jan 26, 2023
Closed
@codeclimate
Copy link

codeclimate bot commented Jan 27, 2023

Code Climate has analyzed commit 8011ea0 and detected 0 issues on this pull request.

View more on Code Climate.

@prachi00
Copy link
Member Author

can we merge this one? @roiLeo

roiLeo
roiLeo approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing padding on offer btn, ✅ code lgtm
Screenshot 2023-01-27 at 08-50-35 Shader 003 KodaDot - NFT Market Explorer

@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Jan 27, 2023
@yangwao
Copy link
Member

yangwao commented Jan 27, 2023

pay 50 usd

@yangwao
Copy link
Member

yangwao commented Jan 27, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 35.02 USD/KSM ~ 1.428 $KSM
🧗 EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU
🔗 0x1c0d02078a55b7dad7684644aea188a5ff64c3202752a6c4f35451d01acdee24

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added paid pull-request has been paid and removed paid pull-request has been paid labels Jan 27, 2023
@yangwao
Copy link
Member

yangwao commented Jan 27, 2023

pay 50 usd

@yangwao yangwao merged commit bb0385c into main Jan 27, 2023
@yangwao yangwao deleted the feat-input-color-fix branch January 27, 2023 10:52
@yangwao
Copy link
Member

yangwao commented Jan 27, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 35.02 USD/KSM ~ 1.428 $KSM
🧗 EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU
🔗 0xf9200b70a21b5ebff625fa0254ecfba7b7005e453bfef06f4a7070cd3642f388

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo approved these changes

@Jarsen136 Jarsen136 Awaiting requested review from Jarsen136 Jarsen136 is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-visual-ok-✅
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

darkmode: input LIST text color
5 participants
@prachi00 @kodabot @yangwao @roiLeo @exezbcz