Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 list button for unlisted owned items #4824

Merged
merged 4 commits into from
Jan 25, 2023

Conversation

petersopko
Copy link
Contributor

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

@petersopko petersopko requested a review from a team as a code owner January 25, 2023 07:48
@petersopko petersopko requested review from roiLeo and vikiival and removed request for a team January 25, 2023 07:48
@kodabot
Copy link
Collaborator

kodabot commented Jan 25, 2023

SUCCESS @petersopko PR for issue #4818 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Jan 25, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 312e229
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63d1563e821d2d000a471ec8
😎 Deploy Preview https://deploy-preview-4824--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

darkmode input text color
Screenshot 2023-01-25 at 08-56-28 The Afterlife KodaDot - NFT Market Explorer

@petersopko
Copy link
Contributor Author

darkmode input

I've intended to solve only the button here, but I unified it with price input on offers. However, this whole section needs reworking:

Also I'm not exactly sure how to proceed with the new theming mixins, should we start using them already? i.e. slowly removing the contents of _dark.css/_light.css and moving to local components?

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on /snek/gallery/331660682-6

✅ wfm

small note (that can be improved later):

@roiLeo roiLeo added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jan 25, 2023
@vikiival
Copy link
Member

pay 30 usd

@yangwao
Copy link
Member

yangwao commented Jan 25, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 33.58 USD/KSM ~ 0.893 $KSM
🧗 FNyt7T1xdbhN7dagf7yGYCRJuE3R45VmTCE3tjzy1rKxa7y
🔗 0xb77b204ee1cee990a09cd4e91cb18145c09b7904d35295260646419df4888181

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jan 25, 2023
@codeclimate
Copy link

codeclimate bot commented Jan 25, 2023

Code Climate has analyzed commit 312e229 and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival vikiival merged commit 3170f94 into kodadot:main Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List option missing when you are owner
5 participants