Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ SidebarFilter #4826

Merged
merged 29 commits into from
Feb 3, 2023
Merged

✨ SidebarFilter #4826

merged 29 commits into from
Feb 3, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Jan 25, 2023 •
edited

This development is longer than I thought

Day spent: ~3

TODO:

PARTIALLY DONE:

DONE:

BLOCKED:

  • figma design (note: can't do menuV3 border without breaking code)
  • properties filters not ready..

PR Type

  • Feature

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Had issue bounty label?

  • Fill up your KSM address: Payout

Screenshot 📸

Screenshot 2023-01-25 at 12-02-13 Low minting fees and carbonless NFTs KodaDot - NFT Market Explorer

Screenshot 2023-01-26 at 16-26-48 Low minting fees and carbonless NFTs KodaDot - NFT Market Explorer

Screenshot 2023-02-01 at 10-13-41 Low minting fees and carbonless NFTs KodaDot - NFT Market Explorer

@netlify
Copy link

netlify bot commented Jan 25, 2023 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit bf23b52
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63dd150a4740fc00088d992a
😎 Deploy Preview https://deploy-preview-4826--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@yangwao yangwao mentioned this pull request Jan 26, 2023
Closed
@yangwao
Copy link
Member

yangwao commented Jan 29, 2023 •
edited by roiLeo

  • make properties sticky on infinity scroll

@exezbcz
Copy link
Member

exezbcz commented Jan 30, 2023 •
edited

image

  • when you scroll and the content is loading slow there is this huge footer.
  • also the sticky sidebar scrolls when you reach "end"
  • Footer when infinity scroll #4867
    image
    collection explore looks weird, when you switch from gallery to collection
    image

Are you going to style the side bar or you will leave to another issue? ah, found the answer.

@exezbcz exezbcz mentioned this pull request Jan 30, 2023
Closed
@roiLeo
Copy link
Contributor Author

roiLeo commented Jan 30, 2023 •
edited

Hey! thank you for the feedback,

when you scroll and the content is loading slow there is this huge footer.

something wrong with footer img, it works well without and I've seen you've open an issue about it 👌

also the sticky sidebar scrolls when you reach "end"

I can't manage to reproduce this one, I keep getting a bug with infinitescroll that load the same data

collection explore looks weird, when you switch from gallery to collection

✅ fixed

Are you going to style the side bar or you will leave to another issue? ah, found the answer.

yup I don't know yet how to make fullwidth borders on sidebar items without breaking container and responsive

By the way I wanted to have your opinion about using checkbox or switch for "Status" filters.
Another thing I found that we miss a design when there is no results, do you have any idea how to display it?

@roiLeo roiLeo marked this pull request as ready for review January 31, 2023 16:06
@roiLeo roiLeo requested a review from a team as a code owner January 31, 2023 16:06
@roiLeo roiLeo requested review from vikiival and Jarsen136 and removed request for a team January 31, 2023 16:06
@exezbcz
Copy link
Member

exezbcz commented Jan 31, 2023

By the way I wanted to have your opinion about using checkbox or switch for "Status" filters. Another thing I found that we miss a design when there is no results, do you have any idea how to display it?

hey!
do you mean this?
image

  • there is meant to be a checkbox

No results - something like this:
image

@yangwao
Copy link
Member

yangwao commented Feb 1, 2023 •
edited

ooh breadcumbs 👏

image

is there anything I can help debug this better for sticky sidebar?

Screen.Recording.2023-02-01.at.10.36.28.mov

Dynamic Item sizes can be solved in

image

Skeletons Items on infinity scroll could be made

  • note: can't do menuV3 border without breaking code)

@roiLeo what's needs to be done on this? Maybe follow up issue on this?

@roiLeo
Copy link
Contributor Author

roiLeo commented Feb 1, 2023

is there anything I can help debug this better for sticky sidebar?

I'll take a look, I'm having a little trouble debugging this one since UI is changing and I can't manage to stop infinite scroll

  • note: can't do menuV3 border without breaking code)

@roiLeo what's needs to be done on this? Maybe follow up issue on this?

find a smart way to add borders without breaking container (I don't want to set fixed width or weird padding)

@exezbcz
Copy link
Member

exezbcz commented Feb 2, 2023

I would make default sidebar open on items, wdyt @exezbcz ?

As it's new UI, people would barely notice that menu burger until they will get used to it (even we are trying mimicking existing experience out there)

Yes, we can; I will provide feedback soon in another issue.

vikiival
vikiival reviewed Feb 2, 2023
View reviewed changes
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦔

components/common/EmptyResult.vue Outdated Show resolved Hide resolved
components/explore/ExploreSort.vue Outdated Show resolved Hide resolved
components/explore/SidebarFilter.vue Outdated Show resolved Hide resolved
components/explore/SidebarFilter.vue
if (pathName && pathName !== route.path) {
return
}
router
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make an util function?

Copy link
Contributor Author

@roiLeo roiLeo Feb 2, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meh. I don't see the point for now, maybe we can improve it later with router history mode

@yangwao
Copy link
Member

yangwao commented Feb 2, 2023

Once this merged, following good to tackle issues are

Jarsen136
Jarsen136 reviewed Feb 2, 2023
View reviewed changes
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small stuff

components/shared/gallery/BreadcrumbsFilter.vue Outdated Show resolved Hide resolved
components/shared/gallery/BreadcrumbsFilter.vue Show resolved Hide resolved
components/shared/gallery/BreadcrumbsFilter.vue Outdated Show resolved Hide resolved
@yangwao
Copy link
Member

yangwao commented Feb 3, 2023

Can we merge it to main 👉👈🥹

@roiLeo
Copy link
Contributor Author

roiLeo commented Feb 3, 2023

Can we merge it to main 👉👈🥹

I think we can push it in beta test stage & wait a bit for production, like I had some problems with "own" toggle that break size of cards.

Many things will follow (#4906, #4893 and more..)

@codeclimate
Copy link

codeclimate bot commented Feb 3, 2023

Code Climate has analyzed commit bf23b52 and detected 0 issues on this pull request.

View more on Code Climate.

@yangwao
Copy link
Member

yangwao commented Feb 3, 2023

wait a bit for production

yes, found some issues which are no-go to go out and we are not in hurry nor critical

feel free add something which we should not miss

payout will be made once fix

@yangwao yangwao mentioned this pull request Feb 3, 2023
Closed
@yangwao yangwao merged commit 3b9248d into kodadot:main Feb 3, 2023
@yangwao
Copy link
Member

yangwao commented Feb 3, 2023

  • NeoSidebarItem
  • min & max price new input design

This was referenced Feb 3, 2023
Closed
Open
@yangwao
Copy link
Member

yangwao commented Feb 3, 2023

okay move to other issues, my chrome is crashing on this pull request lmao

@vikiival
Copy link
Member

vikiival commented Feb 3, 2023

okay move to other issues, my chrome is crashing on this pull request lmao

M2 Pro looking at you

NL258b1b1

@yangwao
Copy link
Member

yangwao commented Feb 3, 2023

M2 Pro looking at you

M2 Max disagrees.

image

@yangwao
Copy link
Member

yangwao commented Feb 3, 2023

pay 100 usd

@yangwao
Copy link
Member

yangwao commented Feb 3, 2023

😍 Perfect, I’ve sent the payout
💵 $100 @ 38.44 USD/KSM ~ 2.601 $KSM
🧗 HguGafrfk8nRP9a4tgJf7hLvSSFie8GtkDjyWFHQ2kDUAMc
🔗 0x60362354e236ae5d24d2664e201c165f2e338714eb4ce9beb37de582c0903a26

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian left review comments

@vikiival vikiival vikiival left review comments

@Jarsen136 Jarsen136 Jarsen136 left review comments

@exezbcz exezbcz exezbcz left review comments

Assignees
No one assigned
Labels
paid pull-request has been paid S-visual-ok-✅
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@roiLeo @yangwao @exezbcz @vikiival @preschian @Jarsen136