Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: long email address on create Identity #4839

Merged
merged 6 commits into from
Jan 29, 2023
Merged

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Jan 26, 2023

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Details:

  • move IdentityForm outside rmrk folder
  • use native html verification
  • BasicInput "max" 32chars prop
  • Vue 3 refactoring
  • fullwidth submit
  • fix darkmode issue

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

@Jarsen136 Jarsen136 requested a review from a team as a code owner January 26, 2023 15:48
@Jarsen136 Jarsen136 requested review from preschian and roiLeo and removed request for a team January 26, 2023 15:48
@kodabot
Copy link
Collaborator

kodabot commented Jan 26, 2023

SUCCESS @Jarsen136 PR for issue #4835 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Jan 26, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 595910e
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63d3895e4221bb00086ff77a
😎 Deploy Preview https://deploy-preview-4839--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mfw I see a form without <form> tag

crycat-crying-cat

small note

  • remove unused code in IdentityForm
  • could you fix/remove box class issue in darkmode
  • can we have full width submit button? 🥺

components/common/IdentityForm.vue Outdated Show resolved Hide resolved
@Jarsen136
Copy link
Contributor Author

mfw I see a form without <form> tag

small note

  • remove unused code in IdentityForm
  • could you fix/remove box class issue in darkmode
  • can we have full width submit button? 🥺

Thanks. I have updated all of them.

@Jarsen136 Jarsen136 requested a review from roiLeo January 27, 2023 07:11
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ code lgtm
704

on the other hand I just saw that the limit of 32 characters must be set on all fields :/

 Error: createType(Call):: Call: failed decoding identity.setIdentity:: Struct: failed on args: {"info":"{\"additional\":\"Vec<(Data,Data)>\",\"display\":\"Data\",\"legal\":\"Data\",\"web\":\"Data\",\"riot\":\"Data\",\"email\":\"Data\",\"pgpFingerprint\":\"Option<[u8;20]>\",\"image\":\"Data\",\"twitter\":\"Data\"}"}:: Struct: failed on info: {"additional":"Vec<(Data,Data)>","display":"Data","legal":"Data","web":"Data","riot":"Data","email":"Data","pgpFingerprint":"Option<[u8;20]>","image":"Data","twitter":"Data"}:: Struct: failed on display: {"_enum":{"None":"Null","Raw":"Bytes","BlakeTwo256":"H256","Sha256":"H256","Keccak256":"H256","ShaThree256":"H256"}}:: Data.Raw values are limited to a maximum length of 32 bytes

@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Jan 27, 2023
@Jarsen136
Copy link
Contributor Author

on the other hand I just saw that the limit of 32 characters must be set on all fields :/

Good catch! I have updated it.

@codeclimate
Copy link

codeclimate bot commented Jan 27, 2023

Code Climate has analyzed commit 595910e and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo roiLeo added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jan 27, 2023
@yangwao
Copy link
Member

yangwao commented Jan 29, 2023

pay 50 usd

@yangwao yangwao merged commit 718096b into kodadot:main Jan 29, 2023
@yangwao
Copy link
Member

yangwao commented Jan 29, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 36.79 USD/KSM ~ 1.359 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0x3b1343d0c447a89f6a6ac36d02ab28986a8c3da1603554225f472ab1590e5532

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BSX: long email address on create Identity
4 participants