Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Redesign: asset page in wallet dialog #4860

Merged
merged 10 commits into from
Jan 31, 2023
Merged

feat: Redesign: asset page in wallet dialog #4860

merged 10 commits into from
Jan 31, 2023

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Jan 30, 2023 •
edited

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Done:

  • functionality
  • vue3 refactor

TODO:

  • implement the UI according to the Figma design
  • mobile compatible

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

image

@kodabot
Copy link
Collaborator

kodabot commented Jan 30, 2023

WARNING @Jarsen136 PR for issue #4829 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #4829

@netlify
Copy link

netlify bot commented Jan 30, 2023 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit edf6040
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63d8eafe55a0ac0008c9d75b
😎 Deploy Preview https://deploy-preview-4860--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Jarsen136
Copy link
Contributor Author

I'm still working on it. Pls do not review the UI before I mark this PR ready to review.

@Jarsen136 Jarsen136 marked this pull request as ready for review January 30, 2023 15:48
@Jarsen136 Jarsen136 requested a review from a team as a code owner January 30, 2023 15:48
@Jarsen136 Jarsen136 requested review from preschian and roiLeo and removed request for a team January 30, 2023 15:48
roiLeo
roiLeo suggested changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When not connected it show my this screen
Screenshot 2023-01-30 at 16-58-25 KodaDot - NFT Market Explorer

VS how it look on beta
Screenshot 2023-01-30 at 17-00-35 KodaDot - NFT Market Explorer

locales/en.json Show resolved Hide resolved
locales/en.json Outdated Show resolved Hide resolved
@Jarsen136
Copy link
Contributor Author

Jarsen136 commented Jan 30, 2023 •
edited

When not connected it show my this screen

✅
Ohh. Please forget it : ) Fixed now.

roiLeo
roiLeo reviewed Jan 30, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small things:

Capture d’écran 2023-01-30 à 5 43 09 PM

@exezbcz
Copy link
Member

exezbcz commented Jan 30, 2023 •
edited

Leftovers from old dialog
image

  • the balance, asset etc text to small, grey please.

image

  • dividers to k-grey, in dark mode and in light.
  • buttons should not have that big gap, only like 10px
    image

@Jarsen136
Copy link
Contributor Author

All the issues mentioned above have been solved. Please check again. @exezbcz @roiLeo

@Jarsen136 Jarsen136 requested a review from roiLeo January 31, 2023 05:55
roiLeo
roiLeo approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When changing account, I can't select current account

The rest is fine for me

@Jarsen136
Copy link
Contributor Author

When changing account, I can't select current account

The rest is fine for me

✅ fixed

@codeclimate
Copy link

codeclimate bot commented Jan 31, 2023

Code Climate has analyzed commit edf6040 and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo roiLeo added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jan 31, 2023
@yangwao
Copy link
Member

yangwao commented Jan 31, 2023

fast tracking bc of need onboarding materials
pay 50 USD

@exezbcz will create visual-ok retroactive issue :D

@yangwao yangwao merged commit d87519b into kodadot:main Jan 31, 2023
@yangwao
Copy link
Member

yangwao commented Jan 31, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 35.34 USD/KSM ~ 1.415 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0x49960c42ff5470f6b75408ab91e04b9b4ffcaa2b4c0c5f5202e7dea9b0e15e8e

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian approved these changes

@roiLeo roiLeo roiLeo approved these changes

Assignees
No one assigned
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redesign: asset page in wallet dialog
6 participants
@Jarsen136 @kodabot @exezbcz @yangwao @preschian @roiLeo