Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 NeoButton icon size error #4934

Merged
merged 2 commits into from
Feb 8, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Feb 7, 2023

No more error

PR Type

  • Bugfix
    Capture d’écran 2023-02-07 à 11 41 24 AM

Context

@roiLeo roiLeo requested a review from a team as a code owner February 7, 2023 10:44
@roiLeo roiLeo requested review from preschian and Jarsen136 and removed request for a team February 7, 2023 10:44
@netlify
Copy link

netlify bot commented Feb 7, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 4eb8f37
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63e39c9d8448ae000862da71
😎 Deploy Preview https://deploy-preview-4934--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@preschian preschian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting, I thought that the error coming from oruga side. because we use fas on icons.ts

@codeclimate
Copy link

codeclimate bot commented Feb 8, 2023

Code Climate has analyzed commit 4eb8f37 and detected 0 issues on this pull request.

View more on Code Climate.

@Jarsen136 Jarsen136 merged commit 622cf45 into kodadot:main Feb 8, 2023
@roiLeo roiLeo deleted the hotfix/lib/NeoButtonIcon branch February 8, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants