🔧 bsx/snek balance issue

[roiLeo]

PR Type

• Bugfix

Context

• Closes Balance issue on mint & buy (only snek) #4941
• fix balance $NaN in wallet sidebar
• fix balance in basilisk create (nft/collection)
• made a change that will check pallet version
  BSX (mainnet) => 82
  BSX (snek Rococo) => 88

Before submitting pull request, please make sure:

• My contribution builds clean without any errors or warnings
• I've merged recent default branch -- main and I've no conflicts
• I've tried to respect high code quality standards
• I've didn't break any original functionality
• I've posted a screenshot of demonstrated change in this PR

Had issue bounty label?

• Fill up your KSM address: Payout

Screenshot 📸

[netlify]

✅ Deploy Preview for koda-nuxt ready!

Name	Link
🔨 Latest commit	985d5ae
🔍 Latest deploy log	https://app.netlify.com/sites/koda-nuxt/deploys/63e56bef51c72300089c7c9f
😎 Deploy Preview	https://deploy-preview-4945--koda-nuxt.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[roiLeo]

@vikiival could you explain this change b4a6274 ? Why it's not working as excepted and where can I find related doc? (nvm pallet doc)

edit: now fixed KSM => Kusama

[Jarsen136]

It seems does not work for me on bsx.

Here is the preview env: https://deploy-preview-4945--koda-nuxt.netlify.app/bsx/create
The balance shows zero.

What's more, it works well on beta env. https://beta.kodadot.xyz/bsx/create

[roiLeo]

It seems does not work for me on bsx.

thank you for your review it helped me to understand what was wrong.

New pallet (Rococo) asset is Kusama while it's currently (mainnet) KSM we will have to make the change when switching
#4941 is blocking me since I can't test some /snek features so I'll probably base it on the prefix

[roiLeo]

made a change that will check pallet version
BSX (mainnet) => 82
BSX (snek Rococo) => 88

lmk if there is another option

[Jarsen136]

WFM

[vikiival]

@vikiival could you explain this

Yeah I was having the same trouble that rococo calls it differently

Apart from that:
Let this roll

Side note:
These data can be fetched from Squid

[vikiival]

Btw wasn't the id issue fixed by checking if KSM returns null?

[roiLeo]

Yeah I was having the same trouble that rococo calls it differently

Any way to know when bsx team make breaking changes?

Side note: These data can be fetched from Squid

where? assetEntities?

Btw wasn't the id issue fixed by checking if KSM returns null?

Since it didn't work on beta I don't think so.

[vikiival]

where? assetEntities?

Yes can write resolver for that:

• Resolver to return KSM asset snek#140

[vikiival]

Nah YOLO

[codeclimate]

Code Climate has analyzed commit 985d5ae and detected 0 issues on this pull request.

View more on Code Climate.