Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valentine Waifu #4954

Merged
merged 15 commits into from
Feb 9, 2023
Merged

Valentine Waifu #4954

merged 15 commits into from
Feb 9, 2023

Conversation

vikiival
Copy link
Member

@vikiival vikiival commented Feb 9, 2023

  • ⚡ new initial set of properties
  • ⚡ unify names
  • 🎉 new waifu model
  • 🌐 new model is slower
  • ⚡ expect correct number of predictions
  • ⚡ updated description for prompt
  • ⚡ use account instead of mail
  • 🌐 translations to waifu mint
  • ⚡ link to waifu mint
  • ♥️ Valentine mint

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at bsx/gallery/14022023-1
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@vikiival vikiival requested a review from a team as a code owner February 9, 2023 14:18
@vikiival vikiival requested review from roiLeo and Jarsen136 and removed request for a team February 9, 2023 14:18
@netlify
Copy link

netlify bot commented Feb 9, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit cbf7a69
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63e5402c90d2060008d43e9c
😎 Deploy Preview https://deploy-preview-4954--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm, except some translation key are missing.

components/bsx/Create/GenerativeMint.vue Outdated Show resolved Hide resolved
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anime

@codeclimate
Copy link

codeclimate bot commented Feb 9, 2023

Code Climate has analyzed commit cbf7a69 and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival vikiival merged commit 30fef10 into main Feb 9, 2023
@vikiival vikiival deleted the 4777-waifu branch February 9, 2023 18:49
@yangwao yangwao mentioned this pull request Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes in Waifu minter
6 participants