Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 4955 gallery item price chart #4968

Merged
merged 5 commits into from
Feb 12, 2023

Conversation

maderi21
Copy link
Contributor

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

@maderi21 maderi21 requested a review from a team as a code owner February 10, 2023 16:08
@maderi21 maderi21 requested review from preschian and vikiival and removed request for a team February 10, 2023 16:08
@kodabot
Copy link
Collaborator

kodabot commented Feb 10, 2023

SUCCESS @maderi21 PR for issue #4955 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Feb 10, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit dc3e8ab
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63e872885505760008018fdb
😎 Deploy Preview https://deploy-preview-4968--koda-nuxt.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@maderi21
Copy link
Contributor Author

two questions here :)

  1. is there some util for converting these currencies?
  2. I have some trouble changing the z-index of the tooltip on price chart, what should the correct solution be here from the design perspective? Is adding margin allowed?

@preschian
Copy link
Member

  1. is there some util for converting these currencies?

you can use this https://github.com/kodadot/nft-gallery/blob/main/components/gallery/GalleryItemAction/GalleryItemActionSection.vue#L49. actually, it would be better if put that section in composables chain

@maderi21
Copy link
Contributor Author

actually, it would be better if put that section in composables chain

moved to composables, and also used it in https://github.com/kodadot/nft-gallery/blob/main/components/gallery/GalleryItemAction/GalleryItemActionSection.vue#L49

@yangwao yangwao mentioned this pull request Feb 11, 2023
@exezbcz
Copy link
Member

exezbcz commented Feb 11, 2023

2. I have some trouble changing the z-index of the tooltip on price chart, what should the correct solution be here from the design perspective? Is adding margin allowed?

yy, first and foremost the design of the popup should be different, but there is a issue with the styling iirc.
image

  • I think it can then overflow the chart and even the card itself if its not going to break other things

@preschian
Copy link
Member

  1. I have some trouble changing the z-index of the tooltip on price chart, what should the correct solution be here from the design perspective? Is adding margin allowed?

yy, first and foremost the design of the popup should be different, but there is a issue with the styling iirc. image

  • I think it can then overflow the chart and even the card itself if its not going to break other things

maybe create a separate issue for this?

@codeclimate
Copy link

codeclimate bot commented Feb 12, 2023

Code Climate has analyzed commit dc3e8ab and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival
Copy link
Member

pay 35 usd

@vikiival vikiival added this pull request to the merge queue Feb 12, 2023
@yangwao
Copy link
Member

yangwao commented Feb 12, 2023

😍 Perfect, I’ve sent the payout
💵 $35 @ 32.73 USD/KSM ~ 1.069 $KSM
🧗 JHJGu2aWyAFBfcso8bR7ma82p15YAavyN6vQfJyWuhniNGa
🔗 0xa600801aea9d29f030988be56db5d28430c9b3efdecb793fe4d0b7ffef5f285f

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Feb 12, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 12, 2023
@yangwao yangwao merged commit 2896cce into kodadot:main Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gallery item chart showing wrong currency
6 participants