Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hide tooltip on scroll #4980

Merged
merged 2 commits into from
Feb 12, 2023

Conversation

Gavin-Gong
Copy link
Contributor

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

Screen.Recording.2023-02-12.at.18.08.59.mov

@Gavin-Gong Gavin-Gong requested a review from a team as a code owner February 12, 2023 10:20
@Gavin-Gong Gavin-Gong requested review from preschian and vikiival and removed request for a team February 12, 2023 10:20
@kodabot
Copy link
Collaborator

kodabot commented Feb 12, 2023

SUCCESS @Gavin-Gong PR for issue #4975 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Feb 12, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 1809960
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63e8bdb422c042000717c9c6
😎 Deploy Preview https://deploy-preview-4980--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented Feb 12, 2023

Code Climate has analyzed commit 1809960 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yangwao
Copy link
Member

yangwao commented Feb 12, 2023

pay 30 usd

@yangwao
Copy link
Member

yangwao commented Feb 12, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 33.22 USD/KSM ~ 0.903 $KSM
🧗 GqheyaQ3c8SFBJYorTXyLW6jvLXKNAXzbad77NXoLYJBXXs
🔗 0x8f764190ac91165a07c29914e3572394c91be09ff848be2f6f6dd96e03bba1e0

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Feb 12, 2023
@yangwao yangwao merged commit 5b66198 into kodadot:main Feb 12, 2023
@Gavin-Gong Gavin-Gong deleted the feat/hide-tooltip-on-scroll branch February 16, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-visual-ok-✅
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hover card on scroll
5 participants