Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 5004 footer gradient and stroke #5011

Merged
merged 3 commits into from
Feb 16, 2023
Merged

fix: 5004 footer gradient and stroke #5011

merged 3 commits into from
Feb 16, 2023

Conversation

maderi21
Copy link
Contributor

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
    image

@maderi21 maderi21 requested a review from a team as a code owner February 14, 2023 20:28
@maderi21 maderi21 requested review from preschian and vikiival and removed request for a team February 14, 2023 20:29
@netlify
Copy link

netlify bot commented Feb 14, 2023 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 510842b
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63ede2fd38f1f800087bfd17
😎 Deploy Preview https://deploy-preview-5011--koda-nuxt.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodabot
Copy link
Collaborator

kodabot commented Feb 14, 2023

SUCCESS @maderi21 PR for issue #5004 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@exezbcz
Copy link
Member

exezbcz commented Feb 14, 2023

weird, this should not happen when switching to light mode
image

@maderi21
Copy link
Contributor Author

weird, this should not happen when switching to light mode image

definitely shouldn't, I will check this in the morning

preschian
preschian requested changes Feb 15, 2023
View reviewed changes
Copy link
Member

@preschian preschian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

light mode broken, like @exezbcz said

@preschian preschian added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Feb 15, 2023
@maderi21
Copy link
Contributor Author

light mode broken, like @exezbcz said

fixed now

@preschian preschian removed the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Feb 15, 2023
@codeclimate
Copy link

codeclimate bot commented Feb 16, 2023

Code Climate has analyzed commit 510842b and detected 0 issues on this pull request.

View more on Code Climate.

vikiival
vikiival approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YOLO

@vikiival vikiival merged commit 7135efc into kodadot:main Feb 16, 2023
@vikiival
Copy link
Member

pay 20 usd

@yangwao
Copy link
Member

yangwao commented Feb 16, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 36.35 USD/KSM ~ 0.55 $KSM
🧗 JHJGu2aWyAFBfcso8bR7ma82p15YAavyN6vQfJyWuhniNGa
🔗 0xb7a97068ecafa9166cfdf0e5d8a8edc29d66763bd22a3a2da9e4e64025a2485a

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian approved these changes

@vikiival vikiival vikiival approved these changes

Assignees
No one assigned
Labels
paid pull-request has been paid S-visual-ok-✅
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Footer gradient
6 participants
@maderi21 @kodabot @exezbcz @vikiival @yangwao @preschian