Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 5003 nft card without name #5013

Merged
merged 10 commits into from
Feb 20, 2023
Merged

fix: 5003 nft card without name #5013

merged 10 commits into from
Feb 20, 2023

Conversation

maderi21
Copy link
Contributor

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
    image

@maderi21 maderi21 requested a review from a team as a code owner February 15, 2023 07:34
@maderi21 maderi21 requested review from vikiival and Jarsen136 and removed request for a team February 15, 2023 07:34
@kodabot
Copy link
Collaborator

kodabot commented Feb 15, 2023

SUCCESS @maderi21 PR for issue #5003 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Feb 15, 2023 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit dfb710c
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63efd9e663c1aa000836dafa
😎 Deploy Preview https://deploy-preview-5013--koda-nuxt.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

preschian
preschian reviewed Feb 15, 2023
View reviewed changes
Copy link
Member

@preschian preschian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add more fallback maybe?

  1. on explore pages https://deploy-preview-5013--koda-nuxt.netlify.app/rmrk/explore/items?page=1

  2. identity components

image

  1. user/collection pages

image

@Jarsen136 Jarsen136 added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Feb 15, 2023
@maderi21
Copy link
Contributor Author

@preschian still sometimes getting this btw:
image

@maderi21
Copy link
Contributor Author

add more fallback maybe?

added

@maderi21
Copy link
Contributor Author

possibly a problem with layout in explore (this would be an issue even if user selected very long collection name). maybe separate issue?
image

Jarsen136
Jarsen136 reviewed Feb 16, 2023
View reviewed changes
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise code lgtm

components/rmrk/Gallery/GalleryCard.vue Outdated Show resolved Hide resolved
components/rmrk/Gallery/GalleryCard.vue Outdated Show resolved Hide resolved
@preschian
Copy link
Member

@preschian still sometimes getting this btw: image

yes, the PR I added before only works on github actions. on local, I think we can just restart the command or trigger save file to reload

@Jarsen136 Jarsen136 removed the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Feb 16, 2023
@exezbcz
Copy link
Member

exezbcz commented Feb 16, 2023

what about putting -- instead of the numbers?

@maderi21
Copy link
Contributor Author

what about putting -- instead of the numbers?

as you wish, I've used '--' instead of the IDs.

@exezbcz
Copy link
Member

exezbcz commented Feb 17, 2023

what about putting -- instead of the numbers?

as you wish, I've used '--' instead of the IDs.

and in the gallery item it should apply as well or not yet?

@maderi21
Copy link
Contributor Author

what about putting -- instead of the numbers?

as you wish, I've used '--' instead of the IDs.

and in the gallery item it should apply as well or not yet?

I don't really know, but I guess your question was a request :D ?

image

Please let me know if anything else is required here, I'm not sure if empty dashes work better than some ID.

@exezbcz
Copy link
Member

exezbcz commented Feb 17, 2023 •
edited

what about putting -- instead of the numbers?

as you wish, I've used '--' instead of the IDs.

and in the gallery item it should apply as well or not yet?

I don't really know, but I guess your question was a request :D ?

image

Please let me know if anything else is required here, I'm not sure if empty dashes work better than some ID.

it was not :D I am not sure how it is with the linking to this collection etc. Your opinion? Id is just long, that was my point :D
but is more descriptive than simple dashes

soo, lets leave the id there and then fix the option to mint nft without name :D

@codeclimate
Copy link

codeclimate bot commented Feb 17, 2023

Code Climate has analyzed commit dfb710c and detected 0 issues on this pull request.

View more on Code Climate.

@maderi21
Copy link
Contributor Author

soo, lets leave the id there and then fix the option to mint nft without name :D

I think I have fixed it elsewhere, although there may be some other problem I've seen conversation about. People won't be allowed to pass empty strings anymore, that should be clear now. Anyways, this PR is, I guess, done now.

@vikiival
Copy link
Member

pay 20 usd

@vikiival vikiival merged commit 781f54d into kodadot:main Feb 20, 2023
@yangwao
Copy link
Member

yangwao commented Feb 20, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 44.89 USD/KSM ~ 0.446 $KSM
🧗 JHJGu2aWyAFBfcso8bR7ma82p15YAavyN6vQfJyWuhniNGa
🔗 0x13f31e15340e615131a5059474b062920c57f1bc6ee1136d471ec6d7c71952b6

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian left review comments

@Jarsen136 Jarsen136 Jarsen136 left review comments

@vikiival vikiival vikiival approved these changes

Assignees
No one assigned
Labels
paid pull-request has been paid S-visual-ok-✅
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NFT card without name
7 participants
@maderi21 @kodabot @preschian @exezbcz @vikiival @yangwao @Jarsen136