fix: 5014 Disable Mint for {{space}} only input

[maderi21]

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

• Bugfix
• Feature
• Refactoring

Context

• Closes Disable mint when NFT name is empty. #5014
• Requires deployment <>

Before submitting pull request, please make sure:

• My contribution builds clean without any errors or warnings
• I've merged recent default branch -- main and I've no conflicts
• I've tried to respect high code quality standards
• I've didn't break any original functionality
• I've posted a screenshot of demonstrated change in this PR

Optional

• I've tested it at </bsx/collection>
• I've tested PR on mobile
• I've written unit tests 🧪
• I've found edge cases

Had issue bounty label?

• Fill up your KSM address: Payout

Community participation

• Are you at KodaDot Discord?

Screenshot 📸

• My fix has changed something on UI; a screenshot is best to understand changes for others.

upper input: space
lower input: empty

[kodabot]

SUCCESS @maderi21 PR for issue #5014 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

[netlify]

✅ Deploy Preview for koda-nuxt ready!

Name	Link
🔨 Latest commit	c539ceb
🔍 Latest deploy log	https://app.netlify.com/sites/koda-nuxt/deploys/63ef221d69c6810008814ca2
😎 Deploy Preview	https://deploy-preview-5019--koda-nuxt.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[maderi21]

@roiLeo is this solution okay? looks like it's doing what we need

[roiLeo]

@roiLeo is this solution okay? looks like it's doing what we need

not the solution I was looking for :/
I don't really like using regex and if I'm correct this one means input shouldn't be empty where there is some BasicInput that can be empty (like in IdentityForm)

[maderi21]

if I'm correct this one means input shouldn't be empty where there is some BasicInput that can be empty (like IdentityForm)

The regex only checks if the input isn't just space/s. It can stay empty, the prop required takes care of that. If there should be allowed spaces somewhere, such as IdentityForm, we can make this an optional prop.

I don't really like using regex

is there something wrong with regex?

//edit: if the regex isn't okay, can you please point me in a direction of solution that would be acceptable?

[roiLeo]

The regex only checks if the input isn't just space/s. It can stay empty, the prop required takes care of that. If there should be allowed spaces somewhere, such as IdentityForm, we can make this an optional prop.

So to understand, with this change I won't be able to create nft with space chars in name?
I thought issue was about empty input but it look like it's working as excepted

I don't really like using regex

is there something wrong with regex?

personal experience it's a pain to maintain and can have side effects

//edit: if the regex isn't okay, can you please point me in a direction of solution that would be acceptable?

maybe @preschian can enlighten us on the original error (are we sure it's not a metadata issue?)

[maderi21]

So to understand, with this change I won't be able to create nft with space chars in name?

that wasn't intended, but that's the effect now. reverting back to draft for now.

[preschian]

maybe @preschian can enlighten us on the original error (are we sure it's not a metadata issue?)

@roiLeo yes, I can reproduce it on snek. check this nft metadata https://beta.kodadot.xyz/snek/gallery/185770742-3 and change the ipfs gateway with the other public ipfs gateway

@maderi21:

• add trim on v-model https://vuejs.org/guide/essentials/forms.html#trim
• use pattern if required === true. maybe this pattern could help https://stackoverflow.com/a/17323588

[codeclimate]

Code Climate has analyzed commit c539ceb and detected 0 issues on this pull request.

View more on Code Climate.

[maderi21]

now the regex which doesn't allow spaces is applied only if the field is required and if the contents of the field are only spaces. otherwise, everything is allowed.

[yangwao]

pay 30 usd

[yangwao]

😍 Perfect, I’ve sent the payout
💵 $30 @ 39.47 USD/KSM ~ 0.76 $KSM
🧗 JHJGu2aWyAFBfcso8bR7ma82p15YAavyN6vQfJyWuhniNGa
🔗 0x8c0668e5e41c0fd9858a444426d91b4ab5f1ca5a1d831961fc75104a19b95c4f

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues