Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚑 MINT Does not work correctly #5037

Merged
merged 4 commits into from
Feb 17, 2023
Merged

🚑 MINT Does not work correctly #5037

merged 4 commits into from
Feb 17, 2023

Conversation

vikiival
Copy link
Member

@vikiival vikiival commented Feb 17, 2023

  • 🚑 BasicInput does not emit any function
  • 🐛 disable collection mint if name, symbol or image is not provided
  • 🐛 Spaces are illegal in names

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>

Before

Screenshot 2023-02-17 at 16 54 14

After

Screenshot 2023-02-17 at 16 54 09

Investigation

My bet is that it was broken by 3b018a3

@vikiival vikiival requested a review from a team as a code owner February 17, 2023 15:53
@vikiival vikiival requested review from preschian and Jarsen136 and removed request for a team February 17, 2023 15:53
@netlify
Copy link

netlify bot commented Feb 17, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit dc6275d
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63efa37f1345330008698476
😎 Deploy Preview https://deploy-preview-5037--koda-nuxt.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

components/shared/form/BasicInput.vue Outdated Show resolved Hide resolved
Co-authored-by: Jarsen <31397967+Jarsen136@users.noreply.github.com>
@codeclimate
Copy link

codeclimate bot commented Feb 17, 2023

Code Climate has analyzed commit dc6275d and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival vikiival merged commit 9eb9e3b into main Feb 17, 2023
@vikiival vikiival deleted the ilegal-mints branch February 17, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collection name changed to something letters and numbers
2 participants