Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dark/light mode hover effect #5059

Merged
merged 4 commits into from
Feb 22, 2023
Merged

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Feb 20, 2023

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

image

image

@Jarsen136 Jarsen136 requested a review from a team as a code owner February 20, 2023 17:16
@Jarsen136 Jarsen136 requested review from roiLeo and vikiival and removed request for a team February 20, 2023 17:16
@kodabot
Copy link
Collaborator

kodabot commented Feb 20, 2023

SUCCESS @Jarsen136 PR for issue #5041 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Feb 20, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit f2bf979
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63f611c75231a20008e801ac
😎 Deploy Preview https://deploy-preview-5059--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@exezbcz
Copy link
Member

exezbcz commented Feb 20, 2023

navbar links should have the same hover effect as footer links

  • this was only for light mode, now it looks like its changed in dark mode as well

Dark mode

image

  • should be same as the under search links - that means to k-shade

Thanks!

@Jarsen136
Copy link
Contributor Author

navbar links should have the same hover effect as footer links

  • this was only for light mode, now it looks like its changed in dark mode as well

Dark mode

image

  • should be same as the under search links - that means to k-shade

Thanks!

✅ Fixed

@exezbcz
Copy link
Member

exezbcz commented Feb 21, 2023

navbar links should have the same hover effect as footer links

  • this was only for light mode, now it looks like its changed in dark mode as well

Dark mode

image

  • should be same as the under search links - that means to k-shade

Thanks!

✅ Fixed

ah, few more things :D
image
image

  • can you apply it here too?

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@vikiival
Copy link
Member

@exezbcz if it is ok, we can merge

@Jarsen136
Copy link
Contributor Author

ah, few more things :D image image

  • can you apply it here too?

✅ DONE

@codeclimate
Copy link

codeclimate bot commented Feb 22, 2023

Code Climate has analyzed commit f2bf979 and detected 0 issues on this pull request.

View more on Code Climate.

@exezbcz
Copy link
Member

exezbcz commented Feb 22, 2023

@vikiival yes

@vikiival
Copy link
Member

pay 20 usd

@vikiival vikiival merged commit 5fbb02d into kodadot:main Feb 22, 2023
@yangwao
Copy link
Member

yangwao commented Feb 22, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 40.35 USD/KSM ~ 0.496 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0xf5eec30796e1a933d153ce4e63a838c6cf1c229fdbe406c6b1396aed01758c9c

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Feb 22, 2023
@yangwao yangwao removed the paid pull-request has been paid label Aug 8, 2023
@yangwao
Copy link
Member

yangwao commented Aug 8, 2023

pay 20 usd

@yangwao
Copy link
Member

yangwao commented Aug 8, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 5 USD/DOT ~ 4 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0xdc4da965ea4c044c4e880d5f78ecb10c3d0ec56915389d5bb8f47a8ec0426025

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-visual-ok-✅
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark/light mode hover effect
6 participants