Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 disabled submit button #5070

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Feb 21, 2023

No disabled pattern

PR Type

  • Bugfix

Context

@roiLeo roiLeo requested a review from a team as a code owner February 21, 2023 10:07
@roiLeo roiLeo requested review from vikiival and Jarsen136 and removed request for a team February 21, 2023 10:07
@netlify
Copy link

netlify bot commented Feb 21, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit fdb223c
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63f497fa418ffe00080488bf
😎 Deploy Preview https://deploy-preview-5070--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented Feb 21, 2023

Code Climate has analyzed commit fdb223c and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival
Copy link
Member

Nooo it will break the ui 😢

@roiLeo
Copy link
Contributor Author

roiLeo commented Feb 21, 2023

Nooo it will break the ui 😢

What do you mean? I'm not able to submit when input are required.
Why would you introduce disabled button only on specific chain?

@vikiival
Copy link
Member

I made it disabled because i was able to make collection with empty metadata

why only one chain?

I forgot to add disabled to other chains 🥺

@roiLeo
Copy link
Contributor Author

roiLeo commented Feb 21, 2023

I made it disabled because i was able to make collection with empty metadata

How? I can't reproduce empty form.
It doesn't need to be that way instead wa can try to fix form.

@preschian
Copy link
Member

so, what was the correct behaviour? I also fix the test case in my PR https://github.com/kodadot/nft-gallery/pull/4869/files#diff-fc481224c5f08977e0f26a5aba1fb7a31e0e787e0ddf992b3a71611faf7c0475R12

@vikiival
Copy link
Member

So the correct fix should be on the side of a package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants