Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5044 checkbox neo #5088

Merged
merged 8 commits into from
Feb 26, 2023
Merged

#5044 checkbox neo #5088

merged 8 commits into from
Feb 26, 2023

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented Feb 22, 2023

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address:
    Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
    Screen Shot 2023-02-21 at 7 02 22 PM

@prachi00 prachi00 requested a review from a team as a code owner February 22, 2023 03:03
@prachi00 prachi00 requested review from preschian and roiLeo and removed request for a team February 22, 2023 03:03
@kodabot
Copy link
Collaborator

kodabot commented Feb 22, 2023

WARNING @prachi00 PR for issue #5044 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #5044

@netlify
Copy link

netlify bot commented Feb 22, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit c46f3d4
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63fb48462ca0620008ad8315
😎 Deploy Preview https://deploy-preview-5088--koda-nuxt.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@prachi00
Copy link
Member Author

prachi00 commented Feb 22, 2023

Known issue:

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ code lgtm

libs/ui/src/components/NeoCheckbox/NeoCheckbox.story.vue Outdated Show resolved Hide resolved
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-02-22 at 09-06-43 Low minting fees and carbonless NFTs KodaDot - NFT Market Explorer

checkmark should be smaller

Known issue: value not getting saved on reload, I tried using nativeValue from oruga but it doesnt work in vue composition, does anyone know any way to do this https://oruga.io/components/checkbox.html

Isn't it working like NeoDropdown component?

@prachi00
Copy link
Member Author

not sure how to get smaller checkbox, its a background image in oruga @roiLeo

@roiLeo
Copy link
Contributor

roiLeo commented Feb 23, 2023

not sure how to get smaller checkbox, its a background image in oruga @roiLeo

background-size: 10px;
background-repeat: no-repeat;
background-position: center;

@roiLeo roiLeo added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked labels Feb 23, 2023
@prachi00
Copy link
Member Author

can we merge this one?

@codeclimate
Copy link

codeclimate bot commented Feb 26, 2023

Code Climate has analyzed commit c46f3d4 and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival vikiival merged commit 06df81b into main Feb 26, 2023
@vikiival vikiival deleted the feat-checkbox branch February 26, 2023 12:11
@vikiival
Copy link
Member

pay 40 usd

@yangwao
Copy link
Member

yangwao commented Feb 26, 2023

😍 Perfect, I’ve sent the payout
💵 $40 @ 38.98 USD/KSM ~ 1.026 $KSM
🧗 EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU
🔗 0xd3f69165843181633df987ac8c42aa19b9e2be0668197874dc2fe9eeb059ac0c

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Feb 26, 2023
@prachi00
Copy link
Member Author

@vikiival can we retry payment on this?

@yangwao yangwao removed the paid pull-request has been paid label Aug 8, 2023
@yangwao
Copy link
Member

yangwao commented Aug 8, 2023

pay 40 usd

@yangwao
Copy link
Member

yangwao commented Aug 8, 2023

😍 Perfect, I’ve sent the payout
💵 $40 @ 5 USD/DOT ~ 8 $DOT
🧗 13Qx65nLd6SwdtjrRyuoEtp9CKXhF651xdHBPaXcvhwKm4N1
🔗 0x9b577a4835227ef8e1744c77fa100253c1b523ea79c63c0490d019bf790d262e

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-visual-ok-✅ S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check box styling
7 participants